Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BITV] 9.4.1.2/7.2 - The "Change color" button in the "Background" section opens an area where you can choose a background color. (1) #41904

Closed
JuliaKirschenheuter opened this issue Nov 29, 2023 · 5 comments · Fixed by nextcloud-libraries/nextcloud-vue#4889 or nextcloud-libraries/nextcloud-vue#5086
Closed

[BITV] 9.4.1.2/7.2 - The "Change color" button in the "Background" section opens an area where you can choose a background color. (1) #41904

JuliaKirschenheuter opened this issue Nov 29, 2023 · 5 comments · Fixed by nextcloud-libraries/nextcloud-vue#4889 or nextcloud-libraries/nextcloud-vue#5086
Assignees
@ShGKme
Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility

Comments

@JuliaKirschenheuter
Copy link
Contributor

JuliaKirschenheuter commented Nov 29, 2023 •
edited
Loading

However, it does not communicate to users whether the area is open or closed, for example, using the "aria-expanded" attribute. Additionally, the labeling of colored radio buttons has been implemented incorrectly, as the "aria-label" attribute is placed on the "label" element instead of the "input" element.

image

https://report.bitvtest.de/default-en/cbedb5ef-4815-4cba-a83d-995599c178c3.html#checkpoint-bfbf07e5c3-v7-n2
@JuliaKirschenheuter JuliaKirschenheuter added 1. to develop Accepted and waiting to be taken care of accessibility labels Nov 29, 2023
@JuliaKirschenheuter JuliaKirschenheuter changed the title [BITV] 9.4.1.2/7.2 - The "Change color" button in the "Background" section opens an area where you can choose a background color. However, it does not communicate to users whether the area is open or closed, for example, using the "aria-expanded" attribute. Additionally, the labeling of colored radio buttons has been implemented incorrectly, as the "aria-label" attribute is placed on the "label" element instead of the "input" element. (1) [BITV] 9.4.1.2/7.2 - The "Change color" button in the "Background" section opens an area where you can choose a background color. (1) Nov 29, 2023
@ShGKme ShGKme self-assigned this Nov 29, 2023
@ShGKme ShGKme added 3. to review Waiting for reviews and removed 1. to develop Accepted and waiting to be taken care of labels Nov 29, 2023
@ShGKme ShGKme mentioned this issue Nov 29, 2023
Merged
@ShGKme
Copy link
Contributor

ShGKme commented Nov 29, 2023

The labelling issue is to be fixed by nextcloud-libraries/nextcloud-vue#4889

aria-expanded is a common NcPopover issue, mentioned in other issues.

@susnux
Copy link
Contributor

susnux commented Nov 30, 2023

waiting for release

@susnux susnux reopened this Nov 30, 2023
@susnux susnux added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 30, 2023
@ShGKme ShGKme closed this as completed Dec 1, 2023
@szaimen
Copy link
Contributor

szaimen commented Jan 5, 2024

aria-expanded is a common NcPopover issue, mentioned in other issues.

aria-expanded doesnt seem to be here still...

@szaimen szaimen reopened this Jan 5, 2024
@ShGKme
Copy link
Contributor

ShGKme commented Jan 5, 2024

Indeed...

@ShGKme ShGKme mentioned this issue Jan 17, 2024
Merged
2 tasks
@ShGKme ShGKme reopened this Jan 18, 2024
@szaimen
Copy link
Contributor

szaimen commented Jan 26, 2024

backport to stable28 seems to be missing:
image

@szaimen szaimen closed this as completed Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ShGKme ShGKme

Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility
Projects
None yet
Milestone
No milestone
4 participants
@susnux @JuliaKirschenheuter @ShGKme @szaimen