Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BITV] 9.1.4.13/3.1 - In the responsive (mobile) view, when focusing on the menu button, a tooltip opens that cannot be closed with the ESC key. (5) #41862

Closed
JuliaKirschenheuter opened this issue Nov 29, 2023 · 3 comments · Fixed by nextcloud-libraries/nextcloud-vue#4888
Closed

[BITV] 9.1.4.13/3.1 - In the responsive (mobile) view, when focusing on the menu button, a tooltip opens that cannot be closed with the ESC key. (5) #41862

JuliaKirschenheuter opened this issue Nov 29, 2023 · 3 comments · Fixed by nextcloud-libraries/nextcloud-vue#4888
Assignees
@ShGKme
Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility

Comments

@JuliaKirschenheuter
Copy link
Contributor

JuliaKirschenheuter commented Nov 29, 2023 •
edited by ShGKme
Loading

image

https://report.bitvtest.de/default-en/cbedb5ef-4815-4cba-a83d-995599c178c3.html#checkpoint-3f706f8e21-v3-n1

9.1.4.13/4.1 - https://report.bitvtest.de/default-en/cbedb5ef-4815-4cba-a83d-995599c178c3.html#checkpoint-3f706f8e21-v4-n1

9.1.4.13/5.1 - https://report.bitvtest.de/default-en/cbedb5ef-4815-4cba-a83d-995599c178c3.html#checkpoint-3f706f8e21-v5-n1

9.1.4.13/9.1 - https://report.bitvtest.de/default-en/cbedb5ef-4815-4cba-a83d-995599c178c3.html#checkpoint-3f706f8e21-v9-n1

9.1.4.13/11.1 - https://report.bitvtest.de/default-en/cbedb5ef-4815-4cba-a83d-995599c178c3.html#checkpoint-3f706f8e21-v11-n1
@JuliaKirschenheuter JuliaKirschenheuter added 1. to develop Accepted and waiting to be taken care of accessibility labels Nov 29, 2023
@JuliaKirschenheuter JuliaKirschenheuter self-assigned this Nov 29, 2023
@ShGKme ShGKme mentioned this issue Nov 29, 2023
Merged
2 tasks
@ShGKme
Copy link
Contributor

ShGKme commented Nov 29, 2023

It is to be fixed by:

  1. fix(NcAppNavigation): make toggle button not the first element for focus-trap nextcloud-libraries/nextcloud-vue#4864 (the button is not initially focused)
  2. fix(NcAppNavigation): closed on mobile initially nextcloud-libraries/nextcloud-vue#4869 (the navigation is not initially open)
  3. fix(NcAppNavigation): replace custom v-tooltip with native title nextcloud-libraries/nextcloud-vue#4888 (replaces custom tooltip with a native title)

@ShGKme
Copy link
Contributor

ShGKme commented Nov 29, 2023

@JuliaKirschenheuter I'm sorry, I missed that you already assigned yourself to the issue ><

@ShGKme ShGKme self-assigned this Nov 29, 2023
@susnux susnux added 4. to release Ready to be released and/or waiting for tests to finish and removed 1. to develop Accepted and waiting to be taken care of labels Nov 30, 2023
@JuliaKirschenheuter
Copy link
Contributor Author

'm sorry, I missed that you already assigned yourself to the issue ><

No problem ;)

@JuliaKirschenheuter JuliaKirschenheuter removed their assignment Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ShGKme ShGKme

Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(NcAppNavigation): replace custom v-tooltip with native title nextcloud-libraries/nextcloud-vue
4 participants
@susnux @JuliaKirschenheuter @ShGKme @szaimen