Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow chunked public upload #4109

Closed
Tracked by #42968
tessus opened this issue Mar 28, 2017 · 44 comments · Fixed by #45652
Closed
Tracked by #42968

Allow chunked public upload #4109

tessus opened this issue Mar 28, 2017 · 44 comments · Fixed by #45652

Comments

@tessus
Copy link

tessus commented Mar 28, 2017

I've noticed that for the file drop or any other screen that allows one to upload a file, there's no way to know in advance if the upload will fail.

Let's say the max upload size is 100 MB and someone tries to upload 105 MB. The upload will fail, but the person still uploaded 100MB for nothing. It would be nice, if there was a way to handle this scenario.
The easiest would be to show a message that tells an uploader the max upload size.

What do you think?

@MorrisJobke
Copy link
Member

We plan to also do chunking on the web UI upload which would mean that we don't have a limit anymore.

Sadly I can't find the issue for this - @rullzer @jancborchardt @ChristophWurst Could you find it or was there none, yet?

@tessus
Copy link
Author

tessus commented Mar 28, 2017

Sounds good, but I suspect that implementing this chunking feature will take a while (months, years).

In the meantime a message would be great and very helpful. Adding the message won't be much of an effort for someone who knows the code.

@MorrisJobke MorrisJobke added design Design, UI, UX, etc. enhancement labels Mar 28, 2017
@MorrisJobke MorrisJobke changed the title Feature Request: show max file size for uploads Show max file size for uploads Apr 5, 2017
@lesykm
Copy link

lesykm commented Feb 28, 2018

May be this could be reused:
https://github.com/owncloud/core/pull/28415/files

@MorrisJobke
Copy link
Member

Web UI does chunking since Nextcloud 13 - we ported exactly this pr in #7056. Don't know if files drop and unauthenticated is also supported as of now. cc @danxuliu

@MorrisJobke MorrisJobke changed the title Show max file size for uploads Show max file size for uploads OR allow chunked public upload Mar 1, 2018
@nextcloud-bot nextcloud-bot added the stale Ticket or PR with no recent activity label Jun 20, 2018
@MorrisJobke MorrisJobke changed the title Show max file size for uploads OR allow chunked public upload Allow chunked public upload Jul 26, 2018
@aryasenna

This comment has been minimized.

@jay-tuckey
Copy link

This feature would be very handy for the university I work for, as we would like to be able to use the "file drop (upload only)" feature for student work submission, including videos projects which can be very large, ~2GiB. Currently we are testing a workaround by just increasing the max upload size, but then the student has no progress visible on how their upload is going or whether it's working. Any progress on this feature for public uploads?

@ChristophWurst
Copy link
Member

@jay-tuckey do you have an Enterprise support subscription? Just asking because then we might be able to work on this in a professional services project.

@jay-tuckey
Copy link

@ChristophWurst unfortunately not at the moment, we may get a subscription in the future if we end up using nextcloud for more areas.

@tessus

This comment has been minimized.

@tessus tessus closed this as completed Mar 4, 2020
@kesselb kesselb removed the design Design, UI, UX, etc. label Mar 4, 2020
@jospoortvliet
Copy link
Member

@tessus what is basic core functionality is in the eye of the beholder. As both private AND enterprise user I've never needed this. There is an easy work-around (just create a guest account) so I'm glad the team focuses on more important things.

@X-Coder
Copy link

X-Coder commented Nov 21, 2021

I just wasted some hours figuring why the upload works everywhere but not on public sharing until I have seen it has to do with missing chunked file upload.

Could you please at least add a hint in the official docs about non available chunk-uploading for public sharing if you don't plan to fix this?

@solracsf solracsf reopened this Dec 1, 2021
@realies
Copy link

realies commented Jul 17, 2023

Chunking in publicly shared folders still does not work.

@ufo56

This comment was marked as spam.

@joshtrichards
Copy link
Member

Historical context in case you feel like making an attempt at prototyping an implementation:

owncloud/core#8955 (comment)

owncloud/core#28415 (comment)

And raw protocol details for chunking:

https://docs.nextcloud.com/server/latest/developer_manual/client_apis/WebDAV/chunking.html

@joshtrichards
Copy link
Member

joshtrichards commented Aug 25, 2023

#30069 may open the door to this functionality being a bit easier to implement from the looks of it

@austin3410
Copy link

Verified this is still an issue on 27.1.4.... at least 6 years later.

@joshtrichards
Copy link
Member

Well, it's an enhancement idea not a bug, and this is an open source project. The issue is still open, which indicates no one has jumped in and completed (volunteered) to do the work. You're welcome make an attempt at implementing it!

@ShaunCurrier
Copy link

Is there a feature bounty program for Nextcloud? I'd love to throw some money that way for this issue.

@austin3410
Copy link

austin3410 commented Dec 15, 2023

Well, it's an enhancement idea not a bug, and this is an open source project. The issue is still open, which indicates no one has jumped in and completed (volunteered) to do the work. You're welcome make an attempt at implementing it!

Without any sort of warning, or in-app acknowledgement that File Drop links are meant for tiny files and anything that may be a "large" file may not work, I would still consider it a bug or at the very least a poorly implemented feature.

I had to spend an entire day searching through logs to finally figure out that the upload methods for authenticated vs unauthenticated sessions are completely different. If there was at least some sort of warning explaining the handicaps of using File Drop links I would've reconsidered my approach instead of wasting time searching for a problem on my end that wasn't there. ¯_(ツ)_/¯

*end of rant lol

@alfonsrv

This comment was marked as off-topic.

@joshtrichards
Copy link
Member

joshtrichards commented Dec 15, 2023

Fair enough.

I don't recall offhand how/if it's noted across the Admin and User manuals. You're welcome to suggest some refined or added language to the appropriate section(s) in one or both manuals by - https://docs.nextcloud.com. There is an edit button in the upper right.

Unfortunately NC itself has no way of knowing the limit because it's environment dependent and determined by the end to end configuration of app servers, web servers and proxies. Technically it's possible to upload fairly large files, even without without chunking, with the appropriate tuning as noted elsewhere in this Issue (and in the >512M Uploads section of the Admin Manual).

But, yes, a note somewhere makes sense if there isn't one.

@austin3410

This comment was marked as off-topic.

@nooblag
Copy link
Contributor

nooblag commented Dec 17, 2023

Great discussion around this.

I only have this to add:

Unfortunately NC itself has no way of knowing the limit because it's environment dependent [...]

That part (at the server end where Nextcloud is running) is discoverable through ini_get('upload_max_filesize') at least...

Yes there would be a challenge detecting with anything much beyond that (i.e. proxies and so on) but that's our point---that all of this would be fixed (made redundant) with a chunked file upload. :)

@TimKraemer
Copy link

I control everything from metal to nextcloud, which would be debian -> docker -> nginx proxy -> php -> nextcloud but I still can't manage to allow guests without registration to upload huge files to file drop - did anyone succeed with a setup like mine?

@realies

This comment was marked as off-topic.

@llek1000

This comment was marked as off-topic.

@EuleMitKeule

This comment has been minimized.

@jospoortvliet
Copy link
Member

For those waiting for this - the public file view is now also nearly finished with its Vue migration, which will allow enabling chunked upload. I'm not sure it will make it in Hub 9 (September), or just miss the deadline and come in Hub 10 (early next year), but it seems very close. Personally also looking forward to it, the new vue-ified public link shares will let us focus on some other nice sharing related features.

@realies
Copy link

realies commented Sep 6, 2024

omfg 7 years and it's finally complete 🍾

@Slopz
Copy link

Slopz commented Sep 6, 2024

What a time to be alive.

@szaimen
Copy link
Contributor

szaimen commented Sep 11, 2024

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.