Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ–ΌοΈ iOS live photos support #40242

Closed
2 tasks done
Tracked by #40676
AndyScherzinger opened this issue Sep 4, 2023 · 5 comments
Closed
2 tasks done
Tracked by #40676

πŸ–ΌοΈ iOS live photos support #40242

AndyScherzinger opened this issue Sep 4, 2023 · 5 comments
Assignees
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement overview ❄️ 2023-Winter
Milestone

Comments

@AndyScherzinger
Copy link
Member

AndyScherzinger commented Sep 4, 2023

How to use GitHub

  • Please use the πŸ‘ reaction to show that you are interested into the same feature.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like
Support iOS Live Photos

This is splitted into 2 part, supporting them regarding DAV operations on the server (i.e. when the jpeg is moved, also move the mov file.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@AndyScherzinger AndyScherzinger added enhancement 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Sep 4, 2023
@AndyScherzinger AndyScherzinger added this to the Nextcloud 28 milestone Sep 4, 2023
@AndyScherzinger AndyScherzinger moved this to πŸ“„ To do (~10 entries) in πŸ“ Files team Sep 4, 2023
@AndyScherzinger AndyScherzinger changed the title Support for iOS live photos server side πŸ–ΌοΈ Support for iOS live photos server side Sep 5, 2023
@AndyScherzinger AndyScherzinger changed the title πŸ–ΌοΈ Support for iOS live photos server side πŸ–ΌοΈ iOS live photos support Sep 6, 2023
@sorbaugh
Copy link
Contributor

cc @tobiasKaminsky this might also need additional work in the clients?

@AndyScherzinger
Copy link
Member Author

cc @tobiasKaminsky this might also need additional work in the clients

Step 1 would be iOS client sending/setting the meta data.

Step 2 would be the clients marking live photos as such combining the image and video on the visualization, specifics to be discussed with @nextcloud/designers, other platforms just display the image and add a 'live' icon to it.

Step 3 is to combine dav operations to be applied to both files.

Step 4 display live photos on all clients.

Step 4 would be the stretch goal

@tobiasKaminsky
Copy link
Member

tobiasKaminsky commented Oct 19, 2023

Step 2:

Step 3:

  • do operations on server, but only on "live photo" capable clients (iOS and Android)
  • corner cases:
    • old client is deleting mov file -> server updates metadata so that jpg is a "plain" image
    • old client moves mov in another subfolder -> still works due to file id

For Step 4: https://support.apple.com/guide/iphone/edit-live-photos-iphd8dbb3291/ios

  • when click on it, it will once play the short video, then stops and shows image

@tobiasKaminsky
Copy link
Member

tobiasKaminsky commented Nov 6, 2023

server: https://livephotos.ltd.nextcloud.com
user: ios

Webdav property: < nc:metadata-files-live-photo />

On server:
sample.jpg: < nc:metadata-files-live-photo>sample.mov</nc:metadata-files-live-photo>
sample.mov: < nc:metadata-files-live-photo>sample.jpg</nc:metadata-files-live-photo>

@artonge artonge moved this from πŸ“„ To do (~10 entries) to πŸ—οΈ In progress in πŸ“ Files team Nov 6, 2023
@AndyScherzinger AndyScherzinger moved this from πŸ—οΈ In progress to πŸ“„ To do (~10 entries) in πŸ“ Files team Nov 21, 2023
@blizzz blizzz removed this from the Nextcloud 28 milestone Nov 23, 2023
@blizzz blizzz added this to the Nextcloud 29 milestone Nov 23, 2023
@AndyScherzinger AndyScherzinger moved this from πŸ“„ To do (~10 entries) to πŸ—οΈ In progress in πŸ“ Files team Dec 5, 2023
@AndyScherzinger AndyScherzinger moved this from πŸ—οΈ In progress to β˜‘οΈ Done in πŸ“ Files team Dec 5, 2023
@AndyScherzinger
Copy link
Member Author

closing, left open is sub-task to display live photos on web, tracked in the remaining task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement overview ❄️ 2023-Winter
Projects
Archived in project
Development

No branches or pull requests

6 participants