-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preview API #3923
Comments
Yes, the Preview API should be its own app and come with a provider manager and an API. The thumbnail API has too many issues. |
So few things:
Well this is hard. Or not hard but resource intensive. What the preview code does now is round either the width or the height to the nearest power of two (round up). We do this so save processing power. And lets face it if a client reqests a 230x230 image. And they get a 256x256 image then they can scale that down just fine. Also the current codes obeys the maxWidth and maxHeight settings for previews.
Well sure
Again, sure.
That one I also find a bit tricky. Because you don't want your server to generate the same preview 5 times. Just because user1 has a quality of 90%, user2 of 85% etc. So long story short. I think a dedicated endpoint is a good idea (webdav?). But lets not get to fancy with all the options. What you want it to request a preview of a given size and then get something fast. And not download a 2048x2048 image if all you wanted was a 100x100 image. |
The options were just a quick thought, so I am fine with whatever I get ;-) |
Would it then be shipped and enabled by default? Otherwise I would need something to check, e.g. in capabilities? |
Probably the best way. |
Easiest and "best" for me/user experience would be if it cannot be disabled ;-) |
This can be clsoed I believe. |
Currently we have a thumbnail API and a preview API, provided by gallery app.
In order to provide proper previews for the clients it would be nice to have a reliable API within the core part.
The API should do
@rullzer (cause we talked about it)
@oparoz as your gallery API is doing all those requirements already :)
The text was updated successfully, but these errors were encountered: