Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User can share root directory #3718

Closed
Ko- opened this issue Mar 5, 2017 · 5 comments
Closed

User can share root directory #3718

Ko- opened this issue Mar 5, 2017 · 5 comments

Comments

@Ko-
Copy link
Contributor

Ko- commented Mar 5, 2017

I would like my users to be able to share their root folder with other users, as a means of allowing admin users to see all data stored by other users.

This is very similar two this ownCloud issue and based on this forum topic.

@nickvergessen
Copy link
Member

IIRC this was removed intentionally, but maybe @schiessle or @rullzer know more.

@rullzer
Copy link
Member

rullzer commented Mar 6, 2017

It was possible (but that was a bug!). We have no way to properly indicate this. Plus you risk running into cyclic shares very very fast.

Long story short it opens up a big can of worms.

Admins most likely have other means of inspecting your data.

@Ko-
Copy link
Contributor Author

Ko- commented Mar 6, 2017

Admins with server access, sure, but I'm talking about people who don't know ssh/sftp/anything. Perhaps 'admin' was the wrong word.

Personally I don't see why cyclic shares should necessarily be a problem, but I'm not familiar with the Nextcloud codebase. I imagine that it could behave just as a symlink pointing to a parent directory, where you just keep appending to the current working directory while traversing directories. Then you only have to make sure that you never search for all content, but only consider one depth level at a time, but that appears feasible to me.

Would it be an easy patch to re-introduce this bug?

@rullzer
Copy link
Member

rullzer commented Mar 7, 2017

Would it be an easy patch to re-introduce this bug?

Nope.

Basically the point is that it introduces a level of nesting and possible cycles. Since the whole nextcloud fs of a user is presented as is. And if in the depths of one directory a file changes we have to propegate this change way back up to the root so sync clients etc know something has changed.

@rullzer
Copy link
Member

rullzer commented Jul 23, 2017

I suggest to try the https://apps.nextcloud.com/apps/impersonate that seems to solve this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants