Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Edit locally available even if user has no edit rights #37058

Open
5 of 9 tasks
marcoambrosini opened this issue Mar 6, 2023 · 5 comments · May be fixed by #36831
Open
5 of 9 tasks

[Bug]: Edit locally available even if user has no edit rights #37058

marcoambrosini opened this issue Mar 6, 2023 · 5 comments · May be fixed by #36831
Labels
3. to review Waiting for reviews 25-feedback 26-feedback bug feature: sharing needs review Needs review to determine if still applicable

Comments

@marcoambrosini
Copy link
Member

⚠️ This issue respects the following points: ⚠️

  • This is a bug, not a question or a configuration/webserver/proxy issue.
  • This issue is not already reported on Github (I've searched it).
  • Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
  • Nextcloud Server is running on 64bit capable CPU, PHP and OS.
  • I agree to follow Nextcloud's Code of Conduct.

Bug description

Edit locally available even if user has no edit rights, the users can click it and start editing the file on their local machine, then they save and get a sync error because they don't have the rights.

Steps to reproduce

  1. Open the actions menu of a file shared with you where you don't have edit rights

Expected behavior

You don't see the "Edit locally" option

Installation method

None

Operating system

None

PHP engine version

None

Web server

None

Database engine version

None

Is this bug present after an update or on a fresh install?

None

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Configuration report

No response

List of activated Apps

-

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

No response

@marcoambrosini marcoambrosini added bug 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Mar 6, 2023
@szaimen
Copy link
Contributor

szaimen commented Mar 6, 2023

Hi, which nc version?

@marcoambrosini
Copy link
Member Author

Forgot to mention: happening at least on 25 and server master

@szaimen
Copy link
Contributor

szaimen commented Mar 6, 2023

Cc @jancborchardt @nimishavijay maybe we should change the wording to open file locally? This would fix the wrong expectations.

@nimishavijay
Copy link
Member

@szaimen another use case for "Open locally" is #36831
We can for sure change it to "Open locally" when the person opening it doesn't have edit rights. Is it possible to get that info?
Since there is yet another use case where "Open locally" makes sense, we could change it everywhere. Only concerned that this will lead to this feature not being used enough because people don't immediately understand the use of opening a file locally. Any thoughts @jancborchardt ?

@jancborchardt
Copy link
Member

I’d be fine with renaming "Edit locally" to "Open locally". It is a bit more generic but will cover both cases.

Any concerns from the marketing side on this @karlitschek @jospoortvliet? If so, at least calling it "Open locally" for when you don’t have edit rights would make sense indeed.

@joshtrichards joshtrichards added 3. to review Waiting for reviews needs review Needs review to determine if still applicable and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews 25-feedback 26-feedback bug feature: sharing needs review Needs review to determine if still applicable
Projects
None yet
5 participants