Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BITV] 9.1.4.3/1.2 - When using a user stylesheet (html {background-color:black;color:white}), the sentence "Nextcloud - a secure place for all your data" at the bottom of the page (white text) is no longer properly readable/discernible. (1) #36950

Closed
2 tasks
AndyScherzinger opened this issue Mar 1, 2023 · 5 comments · Fixed by #38131
Assignees
Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility design Design, UI, UX, etc.

Comments

@AndyScherzinger
Copy link
Member

AndyScherzinger commented Mar 1, 2023

on login page

  • Fix
  • Backport

image

Details

https://report.bitvtest.de/default-en/d63601ac-cb34-4645-8256-66bec78964a0.html#checkpoint-6fe46b78da-v1-n2

@susnux
Copy link
Contributor

susnux commented May 4, 2023

@nimishavijay Not sure if the pill style footer, like on your mockup ( #35482 (comment) ), works out when configuring GDPR or legal information links. What do you think?

rounded box small box wide
pill style with more information Footer aligned with login form full width footer

(I could bet I somewhere already posted this mockups...)

@susnux
Copy link
Contributor

susnux commented May 4, 2023

One could even unify the look with the dashboard which would look like this:
using blurry background

Previous:

using translucent blurry background

@jancborchardt
Copy link
Member

jancborchardt commented May 4, 2023

@susnux looks nice – 2 adjustments:

  • The radius of the main container then also needs to be increased to the one in the Dashboard
  • The Dashboard doesn’t only have transparency but also CSS blur, that needs to be there as well for proper contrast.

@susnux
Copy link
Contributor

susnux commented May 4, 2023

@jancborchardt yes I forgot to add the backdrop-filter property on that mockup (updated it).

@nimishavijay
Copy link
Member

Yes, nice idea to align it with the dashboard! :)
I would add that the pill style container on the bottom can have more padding on the left and right -- around 4-8px more.

@susnux susnux self-assigned this May 8, 2023
@susnux susnux added 2. developing Work in progress 4. to release Ready to be released and/or waiting for tests to finish and removed 1. to develop Accepted and waiting to be taken care of 2. developing Work in progress labels May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility design Design, UI, UX, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants