[Bug]: stable25, nextcloud/server@d4b4135 breaks file action menu items using an img tag #36154
Closed
7 of 9 tasks
Labels
Comments
|
BTW, this also affects that "Edit locally" menu entry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug description
See #35517, from there:
IMHO, the changes to apps.scss break file-actions which use an img-tag for their icons: the width is now 0, what remains is two times the padding which only makes for 28px instead of the necessary 44px.
And:
What I see is that removing the dimensions of the img tag make it size 0. There two different "icon-providers" in the file-actions menu, the correctly working ones use a span:
The other ones have an img tag:
In my view the img has width and height 16px and a padding of 14px. Now, as we have box-sizing=border-box the actual width is then set to 0 and just the padding remains.
Steps to reproduce
Expected behavior
Icon should have the appropriate size (that it is not visible at all is caused by the padding consuming all of the 16px of available space, caused by box-sizing=border-box).
Installation method
None
Operating system
Other
PHP engine version
PHP 8.1
Web server
Apache (supported)
Database engine version
MariaDB
Is this bug present after an update or on a fresh install?
None
Are you using the Nextcloud Server Encryption module?
None
What user-backends are you using?
Configuration report
{ "system": { "instanceid": "***REMOVED SENSITIVE VALUE***", "passwordsalt": "***REMOVED SENSITIVE VALUE***", "secret": "***REMOVED SENSITIVE VALUE***", "trusted_domains": [ "dev1.home.claus-justus-heine.de" ], "default_phone_region": "DE", "datadirectory": "***REMOVED SENSITIVE VALUE***", "dbtype": "mysql", "version": "25.0.3.1", "overwrite.cli.url": "https:\/\/dev1.home.claus-justus-heine.de", "htaccess.RewriteBase": "\/", "dbname": "***REMOVED SENSITIVE VALUE***", "dbhost": "***REMOVED SENSITIVE VALUE***", "dbport": "", "dbtableprefix": "oc_", "mysql.utf8mb4": true, "dbuser": "***REMOVED SENSITIVE VALUE***", "dbpassword": "***REMOVED SENSITIVE VALUE***", "query_log_file": "", "installed": true, "ldapIgnoreNamingRules": false, "loglevel": 0, "logfilemode": 432, "theme": "", "maintenance": false, "debug": true, "verbose_exceptions": true, "session_lifetime": 300, "redis": { "host": "***REMOVED SENSITIVE VALUE***", "port": 6379, "timeout": 0, "password": "***REMOVED SENSITIVE VALUE***", "dbindex": 0 }, "memcache.local": "\\OC\\Memcache\\APCu", "memcache.locking": "\\OC\\Memcache\\Redis", "filelocking.debug": false, "files_no_background_scan": true, "enabledPreviewProviders": [ "OC\\Preview\\Image", "OC\\Preview\\SVG", "OC\\Preview\\TIFF", "OC\\Preview\\PDF", "OC\\Preview\\MarkDown", "OC\\Preview\\MP3", "OC\\Preview\\TXT", "OC\\Preview\\OpenDocument" ], "app_install_overwrite": [ "dokuwikiembedded", "roundcube", "keeporsweep", "bruteforcesettings", "whiteboard", "gpgmailer", "cafevdb", "redaxo4embedded", "ocr", "appointments", "bav", "ownpad", "polls", "tasks", "user_sql", "ldap_contacts_backend", "forms", "files_external_ftp", "audioplayer", "apporder", "circles", "richdocumentscode", "twofactor_admin", "files_texteditor", "files_markdown" ], "ldapProviderFactory": "OCA\\User_LDAP\\LDAPProviderFactory", "trusted_proxies": "***REMOVED SENSITIVE VALUE***", "mail_smtpmode": "smtp", "mail_smtpauth": 1, "mail_sendmailmode": "smtp", "mail_smtpauthtype": "LOGIN", "mail_from_address": "***REMOVED SENSITIVE VALUE***", "mail_domain": "***REMOVED SENSITIVE VALUE***", "mail_smtpsecure": "tls", "mail_smtphost": "***REMOVED SENSITIVE VALUE***", "mail_smtpport": "587", "mail_smtpname": "***REMOVED SENSITIVE VALUE***", "mail_smtppassword": "***REMOVED SENSITIVE VALUE***" } }List of activated Apps
Nextcloud Signing status
No response
Nextcloud Logs
No response
Additional info
No response
The text was updated successfully, but these errors were encountered: