[Bug]: Upgrade from 24.x to 25.0.1 with Web Updater frequently seems to fail / damage the instance #35289
Comments
|
do you have the updater.log or the log from |
|
it seems like there's a pattern. I see here #35287 that the Talk app got disabled as incompatible, probably because at the time of the upgrade the app has not been released yet to the app store |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as abuse.
This comment was marked as abuse.
|
@ygoe Github is only for reporting issue, not to get support or ranting. Feel free to contribute new information about the current bug, see PVince81 question for currently needed input. I would also recommend reading the Nextcloud code of conduct to get a better experience while interacting with the Nextcloud community. |
|
You already have all the information that's needed to fix the code. It hasn't been done so unusable PHP files are still served for those who want to upgrade, completely taking down everything. Please let me know if you're not willing to make that change in the code so I can handle that for future upgrades, should I need any. |
|
I don't see any information besides what the author of this issue reported. Maybe the information you are talking about was not presented properly, so we missed it.
This is a community software that accept changes from anyone, so if you know what needs to be changed, then please open a pull request :) |
|
This is from the first post: That alone says everything. Scroll to the right end to see it all. If you don't know what that means, ask a PHP developer. I'll try to find the time to investigate how to change that file for you. Of course a Nextcloud developer knows far more about this, I can only make the error message go away (I explained how but you chose to hide that information which makes me believe you're not interested in a solution) but actually I know nothing about what the consequences of that change are. |
|
@ygoe This is a last warning, please change your tone, especially:
You are not doing it for me. Myself, or any contributor, do not owe you anything.
I hided three comments of yours that were charged with negativity. Feel free to repost meaningful content in a constructive way. During your research, please note that some work has already been done around that issue: #34712 |
Look for "Talk" (spreed is the old name)
Forwarded it. Please note, our translation is maintained by volunteers. You are welcome to join our translation team at https://www.transifex.com/nextcloud/.
nextcloud/spreed#7648 we already changed the file and released Nextcloud Talk 15 together with Nextcloud 25.
We would like to know why the updater did not update Talk to version 15. That's the reason PVince81 asked for the updater logs.
|
Go to the accessibility settings on index.php/settings/user/theming and tick Disable all keyboard shortcuts Also note that you can simply Ctrl+F twice to reach the default browser search easily. Also weird that you just discover this now. It's part of Nextcloud since quite some time, should be around Nextcloud 20. |
Sorry, somehow missed your reply. Yes, I do have an I quickly skimmed it, and besides maybe local path names there does not seem to be anything too critical contained in it, but then it's quite long and its presence would have been easy to miss... |
|
To answer for my case:
Yes, Spreed / Talk was installed and enabled. As recommended in the manual, the instance uses PHP APCu, and it uses php-fpm so I can use HTTP2. The server runs Debian Bullseye with PHP 7.4.
As documented in my report, in my case (and all other reports I have seen) the upgrade fails with the web updater and can be continued / finalized using the CLI updater. |
|
I also ran into this issue, when I updated NC from 24.0.8 to 25.0.2. I was only able to solve this issue and get Nextcloud working again, by disable the Talk app and perform the occ upgrade once again afterwards. The upgrade process then finished without further issues. As a side-note: before doing the NC updates, I always make sure that every app is updated to the latest version. Only with all apps up to date I start the NC update. |
|
I have the same issue. I had talk install. The site was white. I thought it could be the old php 7.4. So I upgraded to 8.1. Now I have the Picture below. And I don't know, how to describe this. Can anybody explain my fault? This: PHP Fatal error: Declaration of OCA\Talk\Share\RoomShareProvider::getSharesInFolder($userId, OCP\Files\Folder $node, $reshares): array must be compatible with OCP\Share\IShareProvider::getSharesInFolder($userId, OCP\Files\Folder $node, $reshares, $shallow = true) in /var/www/html/nextcloud/apps/spreed/lib/Share/RoomShareProvider.php on line 520 Actual I have nothing. no web page or webupdater.
|
<?php
/**
* @copyright Copyright (c) 2016, ownCloud, Inc.
*
* @author Christoph Wurst <christoph@winzerhof-wurst.at>
* @author Joas Schilling <coding@schilljs.com>
* @author Jörn Friedrich Dreyer <jfd@butonic.de>
* @author Lukas Reschke <lukas@statuscode.ch>
* @author Morris Jobke <hey@morrisjobke.de>
* @author Robin Appelman <robin@icewind.nl>
* @author Roeland Jago Douma <roeland@famdouma.nl>
* @author Sergio BertolÃn <sbertolin@solidgear.es>
* @author Thomas Müller <thomas.mueller@tmit.eu>
* @author Vincent Petry <vincent@nextcloud.com>
*
* @license AGPL-3.0
*
* This code is free software: you can redistribute it and/or modify
* it under the terms of the GNU Affero General Public License, version 3,
* as published by the Free Software Foundation.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU Affero General Public License for more details.
*
* You should have received a copy of the GNU Affero General Public License, version 3,
* along with this program. If not, see <http://www.gnu.org/licenses/>
*
*/
require_once __DIR__ . '/lib/versioncheck.php';
try {
require_once __DIR__ . '/lib/base.php';
OC::handleRequest();
} catch (\OC\ServiceUnavailableException $ex) {
\OC::$server->getLogger()->logException($ex, ['app' => 'index']);
//show the user a detailed error page
OC_Template::printExceptionErrorPage($ex, 503);
} catch (\OCP\HintException $ex) {
try {
OC_Template::printErrorPage($ex->getMessage(), $ex->getHint(), 503);
} catch (Exception $ex2) {
try {
\OC::$server->getLogger()->logException($ex, ['app' => 'index']);
\OC::$server->getLogger()->logException($ex2, ['app' => 'index']);
} catch (Throwable $e) {
// no way to log it properly - but to avoid a white page of death we try harder and ignore this one here
}
//show the user a detailed error page
OC_Template::printExceptionErrorPage($ex, 500);
}
} catch (\OC\User\LoginException $ex) {
$request = \OC::$server->getRequest();
/**
* Routes with the @CORS annotation and other API endpoints should
* not return a webpage, so we only print the error page when html is accepted,
* otherwise we reply with a JSON array like the SecurityMiddleware would do.
*/
if (stripos($request->getHeader('Accept'), 'html') === false) {
http_response_code(401);
header('Content-Type: application/json; charset=utf-8');
echo json_encode(['message' => $ex->getMessage()]);
exit();
}
OC_Template::printErrorPage($ex->getMessage(), $ex->getMessage(), 401);
} catch (Exception $ex) {
\OC::$server->getLogger()->logException($ex, ['app' => 'index']);
//show the user a detailed error page
OC_Template::printExceptionErrorPage($ex, 500);
} catch (Error $ex) {
try {
\OC::$server->getLogger()->logException($ex, ['app' => 'index']);
} catch (Error $e) {
http_response_code(500);
header('Content-Type: text/plain; charset=utf-8');
print("Internal Server Error\n\n");
print("The server encountered an internal error and was unable to complete your request.\n");
print("Please contact the server administrator if this error reappears multiple times, please include the technical details below in your report.\n");
print("More details can be found in the webserver log.\n");
throw $ex;
}
OC_Template::printExceptionErrorPage($ex, 500);
} |
|
ok... after sudo -u www-data php/var/www/nextcloud/occ upgrade it runs all of this. After that app:update --all is function too. But I have the php site above on my website. |
|
Thanks nickvergessen for editing :) I thought I have this right :D |
|
The source code output means your PHP module is not loaded correctly. Check your apache module list, make sure lib apache2 module for php8.1 is installed. Afterwards make sure to restart apache |
php8.1-fpm wasn't enable for apache. Now I havn't the output. But access denied. With domain, and with IP. https://*.de/index.php/login The default site is function :D |
|
This issue has been automatically marked as stale because it has not had recent activity and seems to be missing some essential information. It will be closed if no further activity occurs. Thank you for your contributions. |
Bug description
After updating from 24.x to 25.0.1, the instance is inaccessible.
The web server logs show messages like:
This was reported in the already closed bug #34673 and was announced there to be fixed for 25.0.1, which apparently is not the case.
Since 25.0.1 was made available for web updating to more instances, the upgrade failure reports keep getting added there, but I don't know if it's regarded / on screen in case of a closed bug.
This seems to be a serious upgrade issue.
The broke instance can be rescued by
php occ upgradeand possiblyphp occ app:update --all(this wasn't needed for me)Not sure what to do in cases where no shell access is available.
Steps to reproduce
Expected behavior
Update works and updated instance is accessible through web.
Installation method
Community Manual installation with Archive
Operating system
Debian/Ubuntu
PHP engine version
PHP 7.4
Web server
Apache (supported)
Database engine version
MariaDB
Is this bug present after an update or on a fresh install?
Updated to a major version (ex. 22.2.3 to 23.0.1)
Are you using the Nextcloud Server Encryption module?
Encryption is Disabled
What user-backends are you using?
Configuration report
No response
List of activated Apps
Nextcloud Signing status
No response
Nextcloud Logs
No response
Additional info
No response
The text was updated successfully, but these errors were encountered: