Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow to choose a custom primary color for custom backgrounds #34512

Closed
szaimen opened this issue Oct 10, 2022 · 1 comment
Closed

allow to choose a custom primary color for custom backgrounds #34512

szaimen opened this issue Oct 10, 2022 · 1 comment

Comments

@szaimen
Copy link
Contributor

szaimen commented Oct 10, 2022

    > > I see. However I fear #34433 is then not really resolved as we still run into the problem that the primary color might in most cases not suit your custom background (since for them always blue is primary color), no?

A right, I thought it was the ticket about picking custom color only. Yes, extracting a colour from the custom background is another task

I don't agree that extracting a color from the background color is necessary in order to fix the problem. Allowing to pick a custom color would fix it as well but in that case both need to be possible. (custom color and custom background at the same time; we should even ask the user to choose a custom color in that case directly.)

WDYT @jancborchardt @nimishavijay ?

cc @skjnldsv

Originally posted by @szaimen in #34437 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants