[Bug]: index.php/settings/apps incorrectly shows "All apps are up-to-date." while there is 1 not up-to-date #31915

march42 · 2022-04-09T09:44:40Z

⚠️ This issue respects the following points: ⚠️

This is a bug, not a question or a configuration/webserver/proxy issue.
This issue is not already reported on Github (I've searched it).
Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
I agree to follow Nextcloud's Code of Conduct.

Bug description

The displayed status for available updates is wrong under some conditions.

Under "Your apps" and "Updates" shows "All apps are up-to-date." when there is one update available.
Under "Active apps" shows "All apps are up-to-date." when one and two updates (maybe more) are available.

Steps to reproduce

Nextcloud v23.0.3 and Nextcloud 24.0.0 beta 3
1 or more updates for apps available
check index.php/settings/apps etc. for the status line above the apps list

(Your apps, 1 update, 24.0.0 beta 3)

(Your apps, 1 update, 23.0.3)

(Active apps, 2 updates)

Expected behavior

Displaying the actual count of available updates.

Installation method

Manual installation

Operating system

Debian/Ubuntu

PHP engine version

PHP 7.4

Web server

Apache (supported)

Database engine version

MariaDB

Is this bug present after an update or on a fresh install?

Fresh Nextcloud Server install

Are you using the Nextcloud Server Encryption module?

Encryption is Disabled

What user-backends are you using?

Default user-backend (database)
LDAP/ Active Directory
SSO - SAML
Other

Configuration report

{
    "system": {
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "trusted_domains": [
            "localhost",
            "frija.kleines-miststueck.de",
            "nc.march42.net",
            "march42.net",
            "kleines-miststueck.de",
            "enyo.kleines-miststueck.de"
        ],
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "dbtype": "mysql",
        "version": "23.0.3.2",
        "overwrite.cli.url": "http:\/\/localhost",
        "dbname": "***REMOVED SENSITIVE VALUE***",
        "dbhost": "***REMOVED SENSITIVE VALUE***",
        "dbport": "",
        "dbtableprefix": "oc_",
        "mysql.utf8mb4": true,
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "installed": true,
        "instanceid": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpmode": "smtp",
        "mail_sendmailmode": "pipe",
        "memcache.local": "\\OC\\Memcache\\APCu",
        "default_language": "de",
        "default_locale": "de_DE",
        "default_phone_region": "DE",
        "logtimezone": "Europe\/Berlin",
        "mail_domain": "***REMOVED SENSITIVE VALUE***",
        "mail_smtphost": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpport": "587",
        "mail_smtpsecure": "tls",
        "mail_smtpauth": "true",
        "mail_smtpauthtype": "LOGIN",
        "mail_smtpname": "***REMOVED SENSITIVE VALUE***",
        "mail_smtppassword": "***REMOVED SENSITIVE VALUE***",
        "ldapProviderFactory": "OCA\\User_LDAP\\LDAPProviderFactory",
        "maintenance": false,
        "redis": {
            "host": "***REMOVED SENSITIVE VALUE***",
            "timeout": 2,
            "dbindex": 2
        },
        "memcache.distributed": "\\OC\\Memcache\\Redis",
        "memcache.locking": "\\OC\\Memcache\\Redis",
        "preview_max_x": 600,
        "preview_max_y": 600,
        "enabledPreviewProviders": [
            "OC\\Preview\\Image",
            "OC\\Preview\\TXT",
            "OC\\Preview\\Markdown",
            "OC\\Preview\\SVG",
            "OC\\Preview\\TIFF",
            "OC\\Preview\\Photoshop",
            "OC\\Preview\\PDF"
        ],
        "enable_previews": true,
        "filelocking.enabled": true
    }
}

List of activated Apps

Enabled:
  - activity: 2.15.0
  - backup: 1.0.6
  - calendar: 3.2.2
  - circles: 23.1.0
  - cloud_federation_api: 1.6.0
  - contacts: 4.1.0
  - contactsinteraction: 1.4.0
  - dav: 1.21.0
  - deck: 1.6.1
  - duplicatefinder: 0.0.13
  - event_update_notification: 1.5.0
  - external: 3.10.2
  - federatedfilesharing: 1.13.0
  - federation: 1.13.0
  - files: 1.18.0
  - files_external: 1.15.0
  - files_pdfviewer: 2.4.0
  - files_sharing: 1.15.0
  - files_trashbin: 1.13.0
  - files_versions: 1.16.0
  - files_videoplayer: 1.12.0
  - fileslibreofficeedit: 1.0.4
  - groupfolders: 11.1.2
  - logreader: 2.8.0
  - lookup_server_connector: 1.11.0
  - mail: 1.11.7
  - metadata: 0.15.0
  - notes: 4.3.1
  - notifications: 2.11.1
  - oauth2: 1.11.0
  - password_policy: 1.13.0
  - photos: 1.5.0
  - previewgenerator: 4.0.0
  - privacy: 1.7.0
  - provisioning_api: 1.13.0
  - serverinfo: 1.13.0
  - settings: 1.5.0
  - sharebymail: 1.13.0
  - spreed: 13.0.5
  - systemtags: 1.13.0
  - text: 3.4.1
  - theming: 1.14.0
  - transfer: 0.2.1
  - twofactor_backupcodes: 1.12.0
  - updatenotification: 1.13.0
  - user_ldap: 1.13.1
  - user_status: 1.3.1
  - viewer: 1.7.0
  - workflowengine: 2.5.0
Disabled:
  - accessibility: 1.9.0
  - admin_audit
  - comments: 1.13.0
  - dashboard: 7.3.0
  - encryption
  - files_antivirus: 3.2.2
  - files_rightclick: 1.2.0
  - firstrunwizard: 2.12.0
  - gpgmailer: 0.0.4
  - nextcloud_announcements: 1.12.0
  - recommendations: 1.2.0
  - richdocuments: 5.0.3
  - richdocumentscode: 21.11.204
  - support: 1.6.0
  - survey_client: 1.11.0
  - weather_status: 1.3.0

Nextcloud Signing status

No errors have been found.

Nextcloud Logs

{"reqId":"MQVHJoaOfUlBNJuttNuN","level":3,"time":"2022-04-08T23:22:15+02:00","remoteAddr":"","user":"--","app":"core","method":"","url":"--","message":"OC_Image::fixOrientation(): No image loaded","userAgent":"--","version":"23.0.3.2"}
{"reqId":"MQVHJoaOfUlBNJuttNuN","level":3,"time":"2022-04-08T23:22:18+02:00","remoteAddr":"","user":"--","app":"core","method":"","url":"--","message":"OC_Image::fixOrientation(): No image loaded","userAgent":"--","version":"23.0.3.2"}

Additional info

No response

JordanDIG · 2022-04-09T16:07:36Z

I also have the same problem on the 2 instances in version 23.0.3 and nextcloud 24 in beta 2

tflidd · 2022-04-25T08:20:58Z

I can confirm the issue for NC24RC1.

On NC 22.2.6, I don't have the problem on a similar setup.

szaimen · 2022-04-25T09:53:43Z

When this is happening since 23.0.3 too it must be something that was backported to 23...
#31504
#31591
#31645

szaimen · 2022-04-25T09:57:33Z

Question: does it show the update all button when 2 or 3 apps have updates available?

szaimen · 2022-04-25T09:58:34Z

We might be able to fix it by changing this

server/apps/settings/src/components/AppList.vue

Line 123 in 70c8117

return this.apps.filter(app => app.update).length > 1

to

return this.apps.filter(app => app.update).length > 0

szaimen · 2022-04-25T10:00:22Z

cc @skjnldsv would the above be a good fix or is it not expected that the update all button shows up if only one app update is available?

szaimen · 2022-04-25T10:02:35Z

we should probably also add enabled here:

server/apps/settings/src/components/AppList.vue

Line 126 in 70c8117

    
           return this.hasPendingUpdate && ['installed', 'updates'].includes(this.category)

szaimen · 2022-04-25T10:11:39Z

fix in #32114

march42 added 0. Needs triage Pending check for reproducibility or if it fits our roadmap bug labels Apr 9, 2022

szaimen added 23-feedback labels Apr 9, 2022

rexbron mentioned this issue Apr 10, 2022

[Bug]: App list indicates "All apps up to date" regardless of truth #31921

Closed

8 tasks

szaimen mentioned this issue Apr 25, 2022

[Bug]: App page states all apps are up-to-date but there are updates [NC24RC1] #32103

Closed

8 tasks

szaimen mentioned this issue Apr 25, 2022

fix showing of all apps are up-to-date in apps management #32114

Merged

szaimen added 2. developing Work in progress and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Apr 25, 2022

szaimen closed this as completed in #32114 Apr 26, 2022

szaimen mentioned this issue May 9, 2022

[Bug]: applications updates #32311

Closed

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Bug]: index.php/settings/apps incorrectly shows "All apps are up-to-date." while there is 1 not up-to-date #31915

[Bug]: index.php/settings/apps incorrectly shows "All apps are up-to-date." while there is 1 not up-to-date #31915

march42 commented Apr 9, 2022

JordanDIG commented Apr 9, 2022

tflidd commented Apr 25, 2022

szaimen commented Apr 25, 2022 •

edited

Loading

szaimen commented Apr 25, 2022

szaimen commented Apr 25, 2022

szaimen commented Apr 25, 2022

szaimen commented Apr 25, 2022

szaimen commented Apr 25, 2022

[Bug]: index.php/settings/apps incorrectly shows "All apps are up-to-date." while there is 1 not up-to-date #31915

[Bug]: index.php/settings/apps incorrectly shows "All apps are up-to-date." while there is 1 not up-to-date #31915

Comments

march42 commented Apr 9, 2022

⚠️ This issue respects the following points: ⚠️

Bug description

Steps to reproduce

Expected behavior

Installation method

Operating system

PHP engine version

Web server

Database engine version

Is this bug present after an update or on a fresh install?

Are you using the Nextcloud Server Encryption module?

What user-backends are you using?

Configuration report

List of activated Apps

Nextcloud Signing status

Nextcloud Logs

Additional info

JordanDIG commented Apr 9, 2022

tflidd commented Apr 25, 2022

szaimen commented Apr 25, 2022 • edited Loading

szaimen commented Apr 25, 2022

szaimen commented Apr 25, 2022

szaimen commented Apr 25, 2022

szaimen commented Apr 25, 2022

szaimen commented Apr 25, 2022

szaimen commented Apr 25, 2022 •

edited

Loading