Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable shares for deactivated users #31444

Closed
alx-tuilmenau opened this issue Mar 4, 2022 · 0 comments · Fixed by #39699
Closed

Disable shares for deactivated users #31444

alx-tuilmenau opened this issue Mar 4, 2022 · 0 comments · Fixed by #39699
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement feature: sharing

Comments

@alx-tuilmenau
Copy link
Contributor

alx-tuilmenau commented Mar 4, 2022

How to use GitHub

  • Please use the 👍 reaction to show that you are interested into the same feature.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Is your feature request related to a problem? Please describe.
Implemented in #17077, share links are disabled for deactivated users. In my opinion, this should also happen with normal shares to other users. At the moment, a shared folder of a disabled user is still accessable by others.

Describe the solution you'd like
If a user is deactivated, shares from this user should no longer be visible / accesable for others.

Describe alternatives you've considered
I didn't found an easy way of deactivate shares of a user. My (ugly) solution is to backing up oc_share of this user in a table with same schema insert into my_share_backup select * from oc_share where uid_owner='userid'; and setting permissions in oc_share to 0 update oc_share set permissions=0 where uid_owner='userid', restore data on re-activation of user.

Additional context
We need this for 2 reasons:
First, if deactivating someone because auf violation of TOS, noone should be able to change or access the users data.
Second, if accounts expire, they are deactivated but not removed for a grace period. During this time also the data should not be accessable through other accounts.

(Using NC 22.2.5)

@alx-tuilmenau alx-tuilmenau added 0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement labels Mar 4, 2022
@alx-tuilmenau alx-tuilmenau changed the title Disables shares for deactivated users Disable shares for deactivated users Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement feature: sharing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants