Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable BackgroundCleanupJob when previews are disabled #30793

Closed
PVince81 opened this issue Jan 21, 2022 · 3 comments
Closed

Disable BackgroundCleanupJob when previews are disabled #30793

PVince81 opened this issue Jan 21, 2022 · 3 comments
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap bug good first issue Small tasks with clear documentation about how and in which place you need to fix things in. needs info

Comments

@PVince81
Copy link
Member

When disabling previews altogether, the job "OC\Preview\BackgroundCleanupJob" is still registered.

Now, it's ok that the job is there still but it shouldn't be performing any database queries.

A fix would add a check in it "run()" function to see if previews are enabled in config.php before proceeding.
@PVince81 PVince81 added bug good first issue Small tasks with clear documentation about how and in which place you need to fix things in. 1. to develop Accepted and waiting to be taken care of labels Jan 21, 2022
@Lucarnosky
Copy link
Contributor

Hello, I think I've implemented the solution but I can't test it. When I'm trying to run BackgroundCleanupJobTest.php it give me this error. PHP Fatal error: Uncaught Error: Class "Test\TestCase" not found. How can I test my modification?

@PVince81
Copy link
Member Author

@Lucarnosky see https://docs.nextcloud.com/server/latest/developer_manual/core/unit-testing.html#running-unit-tests-for-the-nextcloud-core-project

./autotest.sh sqlite lib/Preview/BackgroundCleanupJobTest.php

@ghost ghost mentioned this issue May 16, 2022
Closed
@szaimen
Copy link
Contributor

szaimen commented Jan 23, 2023

Hi, please update to 24.0.9 or better 25.0.3 and report back if it fixes the issue. Thank you!

My goal is to add a label like e.g. 25-feedback to this ticket of an up-to-date major Nextcloud version where the bug could be reproduced. However this is not going to work without your help. So thanks for all your effort!

If you don't manage to reproduce the issue in time and the issue gets closed but you can reproduce the issue afterwards, feel free to create a new bug report with up-to-date information by following this link: https://github.com/nextcloud/server/issues/new?assignees=&labels=bug%2C0.+Needs+triage&template=BUG_REPORT.yml&title=%5BBug%5D%3A+

@szaimen szaimen added needs info 0. Needs triage Pending check for reproducibility or if it fits our roadmap and removed 1. to develop Accepted and waiting to be taken care of labels Jan 23, 2023
@szaimen szaimen closed this as completed Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap bug good first issue Small tasks with clear documentation about how and in which place you need to fix things in. needs info
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stop BackgroundCleanupJob when previews are disabled
3 participants
@PVince81 @Lucarnosky @szaimen