Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glitch in German Translation "Persönlich: Du" #14907

Closed
axcro7 opened this issue Mar 29, 2019 · 10 comments
Closed

Glitch in German Translation "Persönlich: Du" #14907

axcro7 opened this issue Mar 29, 2019 · 10 comments
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap bug

Comments

@axcro7
Copy link

axcro7 commented Mar 29, 2019

Steps to reproduce

  1. Open Settings
  2. Change Language to Deutsch (Persönlich: Du)
  3. Go to "Sicherheit" (Security)

Expected behaviour

The string for Last activity for This Session should be "Gerade eben" (seconds ago)

Actual behaviour

It says "in ein paar Sekunden" (in a few seconds)

I wanted to edit the translation at transifex.com but couldn't find that string...

Server configuration

Operating system: Ubuntu Server

Web server: apache

Database: mysql

PHP version: 7.2.16

Nextcloud version: 15.0.5

Updated from an older Nextcloud/ownCloud or fresh install: fresh

Where did you install Nextcloud from: snap

Signing status:

Signing status
Forwards to http://example.com/index.php/settings/integrity/failed

List of activated apps:

Accessibility 1.1.0 Offiziell Activities for shared file downloads 1.4.0 Activity 2.8.2 Offiziell Antivirus for files 2.0.1 Checksum 0.4.2 Collaborative tags 1.5.0 Offiziell Comments 1.5.0 Offiziell Deck 0.5.2 Deleted files 1.5.0 Offiziell Federation 1.5.0 Offiziell File sharing 1.7.0 Offiziell Files Right Click 0.13.0 First run wizard 2.4.0 Offiziell Gallery 18.2.0 Offiziell Group folders 2.0.4 Offiziell Log Reader 2.0.0 Offiziell Metadata 0.9.0 Mind Map 0.0.11 Monitoring 1.5.0 Offiziell Nextcloud announcements 1.4.0 Offiziell Notifications 2.3.0 Offiziell Password policy 1.5.0 Offiziell PDF viewer 1.4.0 Offiziell Polls 0.10.2 Quota warning 1.4.0 Share by mail 1.5.0 Offiziell Support 1.0.0 Offiziell Talk 5.0.2 Offiziell Tasks 0.9.8 Text editor 2.7.0 Offiziell Theming 1.6.0 Offiziell Usage survey 1.3.0 Offiziell User account deletion 0.1.0 Versions 1.8.0 Offiziell Video player 1.4.0 Offiziell
If you have access to your command line run e.g.:
sudo -u www-data php occ app:list
from within your Nextcloud installation folder

Nextcloud configuration:

Config report
{
    "system": {
        "apps_paths": [
            {
                "path": "\/snap\/nextcloud\/current\/htdocs\/apps",
                "url": "\/apps",
                "writable": false
            },
            {
                "path": "\/var\/snap\/nextcloud\/current\/nextcloud\/extra-apps",
                "url": "\/extra-apps",
                "writable": true
            }
        ],
        "supportedDatabases": [
            "mysql"
        ],
        "memcache.locking": "\\OC\\Memcache\\Redis",
        "memcache.local": "\\OC\\Memcache\\Redis",
        "redis": {
            "host": "***REMOVED SENSITIVE VALUE***",
            "port": 0
        },
        "instanceid": "***REMOVED SENSITIVE VALUE***",
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "trusted_domains": [
            "****"
        ],
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "dbtype": "mysql",
        "version": "15.0.5.3",
        "overwrite.cli.url": "https:\/\/cloud.f-sp.at",
        "htaccess.RewriteBase": "\/",
        "dbname": "***REMOVED SENSITIVE VALUE***",
        "dbhost": "***REMOVED SENSITIVE VALUE***",
        "dbport": "",
        "dbtableprefix": "oc_",
        "mysql.utf8mb4": true,
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "installed": true,
        "default_language": "de",
        "default_locale": "de_AT",
        "mail_from_address": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpmode": "smtp",
        "mail_sendmailmode": "smtp",
        "mail_domain": "***REMOVED SENSITIVE VALUE***",
        "mail_smtphost": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpport": "25",
        "maintenance": false
    }
}

Are you using external storage, if yes which one: no

Are you using encryption: no

**Are you using an external user-backend, if yes which one:**no

Client configuration

Browser: Chrome

Operating system: Win 10 Pro

Logs

Web server error log

Web server error log
Insert your webserver log here

Nextcloud log (data/nextcloud.log)

Nextcloud log
Insert your Nextcloud log here

Browser log

Browser log
Insert your browser log here, this could for example include:

a) The javascript console log
b) The network log
c) ...
@axcro7 axcro7 added 0. Needs triage Pending check for reproducibility or if it fits our roadmap bug labels Mar 29, 2019
@kesselb
Copy link
Contributor

kesselb commented Mar 29, 2019

server/core/src/OC/util.js

Lines 124 to 130 in 8709f6b

relativeModifiedDate: function (timestamp) {
var diff = moment().diff(moment(timestamp));
if (diff >= 0 && diff < 45000) {
return t('core', 'seconds ago');
}
return moment(timestamp).fromNow();
},

This function is used to format the activity time. Translation for "seconds ago" are good.

image

Looks ok for me in Nextcloud 16.

@axcro7
Copy link
Author

axcro7 commented Mar 29, 2019

Okay, weird, sometimes it is correct, sometimes not:

2019-03-29 10_25_51-Window

@kesselb
Copy link
Contributor

kesselb commented Mar 29, 2019

Looks like we pass a timestamp newer than current time to moment.js fromNow: https://github.com/moment/moment/blob/develop/locale/de.js#L49

Maybe your server time is behind your client time (the timestamp itself is coming from the server but the output is generated by your client).

@axcro7
Copy link
Author

axcro7 commented Mar 29, 2019

Sounds plausible, but:
The server time (output of date on cli) is a few seconds ahead of my client time

Maybe the condition if (diff >= 0 && diff < 45000) should be changed to just if (diff < 45000) ?

@axcro7
Copy link
Author

axcro7 commented Mar 29, 2019

Looks like some caching issue.

Now both entries where wrong again:
2019-03-29 10_58_51-Window

I the changed the Language to English, but the time strings were still partialy in German:
2019-03-29 10_59_27-Window

after refreshing the page all time strings were German, and the first two are wrong again:
2019-03-29 10_59_47-Window

@rakekniven
Copy link
Member

@tflidd I do not think this is an translation issue. The strings are ok. More an issue related to time ...

@skjnldsv
Copy link
Member

skjnldsv commented Jun 4, 2019

What's the status here?

@rakekniven
Copy link
Member

Just double checked translation strings at Transifex and I am unable to find shown strings.
Should be ok from i18n side.

@skjnldsv
Copy link
Member

skjnldsv commented Jun 4, 2019

Closing then?

@rakekniven
Copy link
Member

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap bug
Projects
None yet
Development

No branches or pull requests

5 participants