From 935565eea80f7b40afbaa28fc6fbe4769b636524 Mon Sep 17 00:00:00 2001 From: Christoph Wurst Date: Fri, 26 Apr 2024 15:38:29 +0200 Subject: [PATCH] perf(db): Sort data for IN before chunking Signed-off-by: Christoph Wurst --- lib/private/Files/Cache/Cache.php | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/private/Files/Cache/Cache.php b/lib/private/Files/Cache/Cache.php index cd88aebb17dfc..1b79e5a648e92 100644 --- a/lib/private/Files/Cache/Cache.php +++ b/lib/private/Files/Cache/Cache.php @@ -623,6 +623,9 @@ private function removeChildren(ICacheEntry $entry) { $query->delete('filecache') ->whereParentInParameter('parentIds'); + // Sorting before chunking allows the db to find the entries close to each + // other in the index + sort($parentIds, SORT_NUMERIC); foreach (array_chunk($parentIds, 1000) as $parentIdChunk) { $query->setParameter('parentIds', $parentIdChunk, IQueryBuilder::PARAM_INT_ARRAY); $query->execute();