From 0273b96eef8111def6bb3d5773a46f543802cb02 Mon Sep 17 00:00:00 2001 From: Faraz Samapoor Date: Thu, 21 Sep 2023 11:40:18 +0330 Subject: [PATCH] Apply suggestions from code review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com> Signed-off-by: Faraz Samapoor --- apps/files_versions/lib/Command/CleanUp.php | 2 +- apps/files_versions/lib/Command/Expire.php | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/apps/files_versions/lib/Command/CleanUp.php b/apps/files_versions/lib/Command/CleanUp.php index 2a19c57710ed8..519b3689a58da 100644 --- a/apps/files_versions/lib/Command/CleanUp.php +++ b/apps/files_versions/lib/Command/CleanUp.php @@ -115,7 +115,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int /** * delete versions for the given user */ - protected function deleteVersions(string $user, string $path = null): void { + protected function deleteVersions(string $user, ?string $path = null): void { \OC_Util::tearDownFS(); \OC_Util::setupFS($user); diff --git a/apps/files_versions/lib/Command/Expire.php b/apps/files_versions/lib/Command/Expire.php index 3744df10093b6..688a6e869e945 100644 --- a/apps/files_versions/lib/Command/Expire.php +++ b/apps/files_versions/lib/Command/Expire.php @@ -53,7 +53,6 @@ public function handle(): void { // In case of external storage and session credentials, the expiration // fails because the command does not have those credentials - /** @var LoggerInterface $logger */ $logger = \OC::$server->get(LoggerInterface::class); $logger->warning($e->getMessage(), [ 'exception' => $e,