Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Talk meetings on shared nc office files with guest cannot be performed #4105

Open
stoneubi opened this issue Sep 19, 2024 · 7 comments
Open
Labels
0. Needs triage bug Something isn't working

Comments

@stoneubi
Copy link

Hi there,

my actual versions are:

  • NC 29.0.7
  • Talk 19.0.9
  • NC Office 8.4.6
  • Share settings: allow

grafik

Description / steps to reproduce:

  • create a new e.g. presentation

  • press the share button directly at the presentation creation / modify screen and select Chat
    grafik

  • as described you have to share the presentation before you can discuss it -> share the presentation to a guest per email invitation

  • allow the guest to edit the presentation

  • click on the link at the invitation email

  • the browser opens, for a second you can see the regular view same as if you share files and on the right side there would be the chat part but the browser changes to the next screen where the presentation opens in nextcloud office

  • at this stage you cannot chat with anyone other -> there is no chat part and you cannot open talk or chat

The thing is that you want to discuss a presentation with a guest, you share the presentation but then you cannot use talk.

If you close the presentation, the chat view will be visible:
grafik

and you can open the chat part -> you have to enter a name. Now you are in the chat part but cannot modify the presentation together with someone else.

How can the system be configured to allow talk meetings during a collaborate file creation / modification with guests = no nextcloud user.

Thank you,
Stoneubi

@stoneubi stoneubi added 0. Needs triage bug Something isn't working labels Sep 19, 2024
@Antreesy
Copy link

Antreesy commented Sep 19, 2024

@nickvergessen
Copy link
Member

should be backported to stable28/29 / if nextcloud/vue version is 8.13.0 or higher

Can you check and confirm?

@Antreesy
Copy link

Antreesy commented Oct 10, 2024

Fix is in there and restores access to chat sidebar from public link.
But Office integration doesn't show a toggle for guests, it seems. so I'd check with Office team, if they can provide it

Guest User
Image Image

@juliusknorr
Copy link
Member

Two questions:

  • How can we check from the richdocuments app if the sidebra should be shown (assuming there is a setting for it from the above screenshots)
  • How can we trigger/toggle the sidebar in the frontend? Maybe you have any code pointers there?

@Antreesy
Copy link

  • How can we check from the richdocuments app

This returns a conversation token for public share:
https://github.com/nextcloud/spreed/blob/1ccbf67da231c37801c1406b10000144125aec35/src/services/filesIntegrationServices.js#L28-L31

If response is successfull = Talk is available, and conversation can be joined

  • How can we trigger/toggle the sidebar in the frontend?

We already have a trigger mounted in DOM - in NC header (but it's behind the Office integration): https://github.com/nextcloud/spreed/blob/976f67921c09848e0780cd8c1b70b663cf587c50/src/mainPublicShareSidebar.js#L74
Image

Maybe just shrinking of Office integration would be enough (similar to how it's done for Files app?)

@Antreesy Antreesy transferred this issue from nextcloud/spreed Oct 10, 2024
@Antreesy Antreesy removed their assignment Oct 10, 2024
@Antreesy Antreesy added 0. Needs triage and removed 1. to develop Waiting for a developer labels Oct 10, 2024
@juliusknorr
Copy link
Member

This returns a conversation token for public share:
https://github.com/nextcloud/spreed/blob/1ccbf67da231c37801c1406b10000144125aec35/src/services/filesIntegrationServices.js#L28-L31

If response is successfull = Talk is available, and conversation can be joined

We'd need a backend way but guess we can dig this up from the route then.

Thanks for the pointers

@scubamuc
Copy link

scubamuc commented Oct 22, 2024

... sorry for barging in...

How can the system be configured to allow talk meetings during a collaborate file creation / modification with guests = no nextcloud user.

@stoneubi, you can define app access for guests in the allow list... without a share

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants