OCP\Files\NotFoundException when sharing a subfolder "with yourself" (via group)

[brrrrrrrt]

Steps to reproduce

1. create a group, eg. "Test"
2. add yourself to the group
3. create "Folder1"
4. inside Folder1 create "Folder2"
5. share Folder2 with your group "Test"
6. browse to the root of your files

Expected behaviour

"recommended section" should be shown

Actual behaviour

"recommended section" is missing, instead, every time you browse to the files app an exception will be logged, that /username/files/Folder2 was not found

Operating system

Linux 4.9.0-9-amd64 #1 SMP Debian 4.9.168-1 (2019-04-12) x86_64

Webserver

Apache (apache2handler)

Database

Maria 10.1.38

PHP Version

7.3.5-1+0~20190503093827.38+stretch~1.gbp60a41b
Modules loaded: Core, date, libxml, openssl, pcre, zlib, filter, hash, Reflection, SPL, sodium, session, standard, apache2handler, mysqlnd, PDO, xml, apcu, bz2, calendar, ctype, curl, dom, mbstring, fileinfo, ftp, gd, gettext, iconv, igbinary, imagick, imap, intl, json, exif, msgpack, mysqli, pdo_mysql, apc, posix, readline, redis, shmop, SimpleXML, soap, sockets, sysvmsg, sysvsem, sysvshm, tokenizer, wddx, xmlreader, xmlwriter, xsl, zip, Phar, memcached, Zend OPcache

Nextcloud version

16.0.1 - 16.0.1.1

List of activated apps

Enabled:
 - accessibility: 1.2.0
 - activity: 2.9.1
 - admin_audit: 1.6.0
 - apporder: 0.7.1
 - bookmarks: 1.0.5
 - bruteforcesettings: 1.3.0
 - calendar: 1.7.0
 - cloud_federation_api: 0.2.0
 - comments: 1.6.0
 - contacts: 3.1.1
 - dav: 1.9.2
 - deck: 0.6.2
 - federatedfilesharing: 1.6.0
 - federation: 1.6.0
 - files: 1.11.0
 - files_external: 1.7.0
 - files_pdfviewer: 1.5.0
 - files_rightclick: 0.13.0
 - files_sharing: 1.8.0
 - files_texteditor: 2.8.0
 - files_trashbin: 1.6.0
 - files_versions: 1.9.0
 - files_videoplayer: 1.5.0
 - firstrunwizard: 2.5.0
 - gallery: 18.3.0
 - impersonate: 1.3.0
 - issuetemplate: 0.5.0
 - logreader: 2.1.0
 - lookup_server_connector: 1.4.0
 - mail: 0.15.1
 - nextcloud_announcements: 1.5.0
 - notes: 2.6.0
 - notifications: 2.4.1
 - oauth2: 1.4.2
 - password_policy: 1.6.0
 - privacy: 1.0.0
 - provisioning_api: 1.6.0
 - recommendations: 0.4.0
 - serverinfo: 1.6.0
 - sharebymail: 1.6.0
 - socialsharing_email: 1.0.5
 - support: 1.0.0
 - survey_client: 1.4.0
 - systemtags: 1.6.0
 - tasks: 0.10.1
 - theming: 1.7.0
 - twofactor_backupcodes: 1.5.0
 - updatenotification: 1.6.0
 - viewer: 1.0.0
 - workflowengine: 1.6.0
Disabled:
 - encryption
 - user_ldap

Configuration (config/config.php)

{
    "debug": true,
    "instanceid": "***REMOVED SENSITIVE VALUE***",
    "passwordsalt": "***REMOVED SENSITIVE VALUE***",
    "trusted_domains": [
        "cloud.nf-engineering.com"
    ],
    "datadirectory": "***REMOVED SENSITIVE VALUE***",
    "dbtype": "mysql",
    "version": "16.0.1.1",
    "dbname": "***REMOVED SENSITIVE VALUE***",
    "dbhost": "***REMOVED SENSITIVE VALUE***",
    "dbtableprefix": "oc_",
    "dbuser": "***REMOVED SENSITIVE VALUE***",
    "dbpassword": "***REMOVED SENSITIVE VALUE***",
    "installed": true,
    "forcessl": true,
    "mail_from_address": "***REMOVED SENSITIVE VALUE***",
    "mail_smtpmode": "smtp",
    "mail_domain": "***REMOVED SENSITIVE VALUE***",
    "asset-pipeline.enabled": false,
    "enable_previews": true,
    "preview_max_x": 1000,
    "preview_max_y": 1000,
    "preview_max_scale_factor": 100,
    "htaccess.RewriteBase": "\/",
    "loglevel": 2,
    "theme": "",
    "maintenance": false,
    "secret": "***REMOVED SENSITIVE VALUE***",
    "memcache.local": "\\OC\\Memcache\\APCu",
    "filelocking.enabled": "true",
    "memcache.locking": "\\OC\\Memcache\\Redis",
    "redis": {
        "host": "***REMOVED SENSITIVE VALUE***",
        "port": 0,
        "dbindex": 0,
        "timeout": 1.5
    },
    "enabledPreviewProviders": [
        "OC\\Preview\\Image",
        "OC\\Preview\\MP3",
        "OC\\Preview\\TXT",
        "OC\\Preview\\MarkDown",
        "OC\\Preview\\PDF",
        "OC\\Preview\\SVG"
    ],
    "trashbin_retention_obligation": "auto",
    "appstore.experimental.enabled": true,
    "mail_smtphost": "***REMOVED SENSITIVE VALUE***",
    "mail_smtpport": "25",
    "overwrite.cli.url": "https:\/\/cloud.nf-engineering.com",
    "updater.release.channel": "stable",
    "mysql.utf8mb4": true
}

Browser

Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/74.0.3729.169 Safari/537.36

Nextcloud Log

	OCP\Files\NotFoundException: /username/files/Folder2
/var/www/nextcloud/lib/private/Files/Node/Folder.php - line 134:

OC\Files\Node\Root->get("/username/files/Folder2")

/var/www/nextcloud/apps/recommendations/lib/Service/RecentlySharedFilesSource.php - line 122:

OC\Files\Node\Folder->get("/Folder2")

<<closure>>

OCA\Recommendations\Service\RecentlySharedFilesSource->OCA\Recommendations\Service\{closure}("*** sensiti ... *")

/var/www/nextcloud/apps/recommendations/lib/Service/RecentlySharedFilesSource.php - line 127:

array_map(Closure {}, [ "*** sensi ... }])

/var/www/nextcloud/apps/recommendations/lib/Service/RecommendationService.php - line 91:

OCA\Recommendations\Service\RecentlySharedFilesSource->getMostRecentRecommendation(OC\User\User {}, 6)

<<closure>>

OCA\Recommendations\Service\RecommendationService->OCA\Recommendations\Service\{closure}("*** sensiti ... *")

/var/www/nextcloud/apps/recommendations/lib/Service/RecommendationService.php - line 92:

array_reduce([ OCA\Recomm ... "], Closure {}, [])

/var/www/nextcloud/apps/recommendations/lib/Controller/RecommendationController.php - line 63:

OCA\Recommendations\Service\RecommendationService->getRecommendations(OC\User\User {})

/var/www/nextcloud/lib/private/AppFramework/Http/Dispatcher.php - line 166:

OCA\Recommendations\Controller\RecommendationController->index()

/var/www/nextcloud/lib/private/AppFramework/Http/Dispatcher.php - line 99:

OC\AppFramework\Http\Dispatcher->executeController(OCA\Recommen ... {}, "index")

/var/www/nextcloud/lib/private/AppFramework/App.php - line 126:

OC\AppFramework\Http\Dispatcher->dispatch(OCA\Recommen ... {}, "index")

/var/www/nextcloud/lib/private/AppFramework/Routing/RouteActionHandler.php - line 47:

OC\AppFramework\App::main("OCA\\Recomm ... r", "index", OC\AppFramew ... {}, { _route: "r ... "})

<<closure>>

OC\AppFramework\Routing\RouteActionHandler->__invoke({ _route: "r ... "})

/var/www/nextcloud/lib/private/Route/Router.php - line 297:

call_user_func(OC\AppFramew ... {}, { _route: "r ... "})

/var/www/nextcloud/lib/base.php - line 975:

OC\Route\Router->match("/apps/recom ... s")

/var/www/nextcloud/index.php - line 42:

OC::handleRequest()

Browser Log

...
(anonymous) @ app.js:343
u @ main.js:39
fireWith @ main.js:39
ready @ main.js:39
O @ main.js:39
main.js:7 GET https://mydomain.com/apps/recommendations/api/recommendations 500 (Internal Server Error)
(anonymous) @ main.js:7
...

[ChristophWurst]

This should be fixed with #79