No thumbnail of video files

[Valdnet]

Describe the bug
Video thumbnails (mp4) are not displayed when viewing photos or videos.

Expected behavior
Display the standard thumbnail of video files (mp4) or the thumbnail of the video file frame.

Screenshots

Apps:
Nextcloud 22.1.0
Photos 1.4.0
Firefox 91.0.1

[PVince81]

confirmed happening also on Nextcloud 22.1.1 with the bundled photos app:

[PVince81]

Very strange, on stable22 I was able to have the thumbnails generated.

And the error about the missing "empty.svg" only happens when switching sections in the left sidebar.
I suspect that the latter might be a webpack issue where the SVG is perhaps not compiled in.

[PVince81]

ok, on my local setup I have the "Movie" preview provider installed, I'll retry with it disabled so we should see placeholders for the videos I guess

[PVince81]

alright, bug confirmed when the "Movie" provider is disabled:

on stable22

• server stable22 389123ac3c17a09759ef78571417f4819fc16884
• photos stable22 4142e5a

[PVince81]

I managed to make the error disappear by replacing https://github.com/nextcloud/photos/blob/stable22/src/components/EmptyContent.vue#L102 with

const illustration = await import('../assets/Illustrations/empty.svg')

I suspect it might not be possible to put a variable name when importing like this, but not sure.
Maybe someone more familiar with webpack chunks can have a look.

Sadly this doesn't make the placeholder thumbnail appear, the web UI still looks like above screenshot.

Also I checked those SVGs and the "empty.svg" one seems to be for a completely empty list, not a single item's placeholder.
So probably something else is broken here.

@skjnldsv can you have a look ?

[skjnldsv]

I suspect it might not be possible to put a variable name when importing like this, but not sure.

Yes it is, webpack understands it and split chunks accordingly

[skjnldsv]

#842

[skjnldsv]

Completely forgot about this, I forgot to backport.

[PVince81]

the backport was done here: #876