Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support SystemD Type=notify #452

Closed
Deric-W opened this issue May 20, 2024 · 0 comments · Fixed by #456
Closed

Support SystemD Type=notify #452

Deric-W opened this issue May 20, 2024 · 0 comments · Fixed by #456

Comments

@Deric-W
Copy link
Contributor

Deric-W commented May 20, 2024

In NixOS the notify_push service is using ExecStartPost for calling notify_push:setup once the server is started, which I think is a valid way to handle calling the command.

Currently this setup sometimes fails when a Unix socket is used (see NixOS/nixpkgs#312633) since SystemD considers the service started as soon as it is executed which allows notify_push:setup to run before the socket is created, leading to a failure.

If notify_push would communicate to SystemD when it is operational (for example by using sd-notify) then Type=notify could be used which would delay dependent actions until the socket is created.

If the addition of such a feature is acceptable then I could work on a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant