Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EMail Notification change & conflicting HTML ID attribute? #1259

Closed
EngelPika32 opened this issue Aug 29, 2022 · 1 comment · Fixed by #1261
Closed

EMail Notification change & conflicting HTML ID attribute? #1259

EngelPika32 opened this issue Aug 29, 2022 · 1 comment · Fixed by #1261

Comments

@EngelPika32
Copy link

EngelPika32 commented Aug 29, 2022

Related issue (with images) for activity-app: nextcloud/activity#897

Steps to reproduce

Updated from NC22 (latest patch) to NC23 (latest patch).

Since that update an additional option appeared under settings/user/notifications. [The top one from the images.]

Expected behaviour

No un-asked e-mail notification.
I dunno what these "unhandled notifications" are, but I never asked to receive E-Mails for stuff I've selected "push" for.

Additionally, I don't see any admin option about this to set defaults.

Actual behaviour

Un-asked e-mail notification from (apparently) a new option.
The HTML code includes ID conflicts (more than one element with the same ID).


PR adding the new option: #1074
File (in notifications): src/views/UserSettings.vue:30
File (in activity): templates/settings/form.php:73

One of these has to change their ID.


Server configuration

Operating system: Arch Linux

Web server: caddy

Database: MariaDB

PHP version: 8.0

Nextcloud version: (see Nextcloud admin page) 23.0.8

Where did you install Nextcloud from: Docker (fpm)

Signing status: No errors have been found.

Login as admin user into your Nextcloud and access
http://example.com/index.php/settings/integrity/failed
paste the results here.

List of activated apps:

If you have access to your command line run e.g.:
sudo -u www-data php occ app:list
from within your Nextcloud installation folder

Nextcloud configuration:

If you have access to your command line run e.g.:
sudo -u www-data php occ config:list system
from within your Nextcloud installation folder

or

Insert your config.php content here
Make sure to remove all sensitive content such as passwords. (e.g. database password, passwordsalt, secret, smtp password, …)

Are you using an external user-backend, if yes which one: LDAP/ActiveDirectory/Webdav/...

Client configuration

Browser:

Operating system:

Logs

Nextcloud log (data/owncloud.log)

Insert your Nextcloud log here

Browser log

Insert your browser log here, this could for example include:

a) The javascript console log
b) The network log 
c) ...
@nickvergessen
Copy link
Member

Great find. Let's adjust it in this app, as the activity app got some rework and migration to another JS code base in the meantime, so backporting there is much harder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants