Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick search bar alignment #9919

Closed
Tracked by #80
ChristophWurst opened this issue Jul 25, 2024 · 7 comments · Fixed by #9938
Closed
Tracked by #80

Quick search bar alignment #9919

ChristophWurst opened this issue Jul 25, 2024 · 7 comments · Fixed by #9938

Comments

@ChristophWurst
Copy link
Member

ChristophWurst commented Jul 25, 2024

Steps to reproduce

  1. Set up an account

Expected behavior

Good design

Actual behavior

  1. The layout of the search bar going completely to the right
  2. The scrollbar starts below which looks somehow weird

image

Mail app version

v4.0.0-alpha1

Mailserver or service

No response

Operating system

No response

PHP engine version

None

Web server

None

Database

None

Additional info

No response

@ChristophWurst
Copy link
Member Author

@jancborchardt @nimishavijay we need your input.

  1. The bar is moved to the right to make room for the nav toggle button.
  2. The scrollbar starts below because the search bar is sticky.

@ChristophWurst
Copy link
Member Author

The advanced search icon was moved into the input intentionally: #9755

@nimishavijay
Copy link
Member

There seems to be extra space to the right of the nav toggle, where did that come from?

Should be: (margin on search-messages is -1px 0 0 48px;)
image

But on the current daily: (margin on search-messages is -1px 0 0 52px;)
image

Tbh scrollbar looks great to me, not going all the way up is expected behaviour at this point (ref. Gmail (scrollbar focused for clarity), Confluence, Notion)

image
image
image

@ChristophWurst
Copy link
Member Author

Tbh scrollbar looks great to me, not going all the way up is expected behaviour at this point (ref. Gmail (scrollbar focused for clarity), Confluence, Notion)

If we compare to Talk with the sticky conversation header, the header has a subtle border at the bottom. We could also have one for the sticky search bar in Mail. That may make the scrollbar a bit less "weird".

@ChristophWurst
Copy link
Member Author

ChristophWurst commented Jul 26, 2024

Before After
Bildschirmfoto vom 2024-07-26 09-35-51 Bildschirmfoto vom 2024-07-26 09-35-47

(spacing above/below the line is not ideal)

@ChristophWurst
Copy link
Member Author

@nimishavijay ^

@nimishavijay
Copy link
Member

That could work! but the border should be a couple of pixels higher, so a bit course to the search bar and farther away from the list item such that the space on the top and bottom of the search bar should is the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

2 participants