Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After zipping a folder, it reports that it is "created in a public folder" (but it is not in such a folder) #290

Closed
Omemanti opened this issue Oct 12, 2024 · 4 comments · Fixed by #304
Labels
1. to develop bug Something isn't working

Comments

@Omemanti
Copy link

After creating a zip file, it reports in properties as well in the notification email that the zipfile was created in a public folder
After checking, it does not seem to be in a public or shared folder.

Steps to reproduce

  1. User zipper in nextcloud to compress a folder
  2. It reports in properties as well in the notification email that the zipfile was created in a public folder

Expected behaviour

When created in a non public folder, the notification should not tell that it was done so.

Also, I don't have proof that it is in a public folder, but for the sake of certainty, it should be checked if it definitely is not creating a public folder. (in case i'm not proficient enough to find if it is creating a public folder.)

Actual behaviour

It sends out a notification via email that the file was created in a public folder.

Server configuration

Web server: Docker

Database: Maria

PHP version: 8.2.24

**Nextcloud version: 30.0.0

  • files: 2.2.0
  • files_downloadlimit: 3.0.0
  • files_external: 1.22.0
  • files_notify_redis: 0.3.4
  • files_pdfviewer: 3.0.0
  • files_reminders: 1.3.0
  • files_sharing: 1.22.0
  • files_trashbin: 1.20.1
  • files_versions: 1.23.0
  • files_zip: 2.1.0
  • groupfolders: 18.0.2
  • updatenotification: 1.20.0
  • webhook_listeners: 1.1.0-dev

Image

@Omemanti Omemanti added 0. Needs triage bug Something isn't working labels Oct 12, 2024
@Omemanti Omemanti changed the title After zipping a folder, it reports that it is "created in a public folder" (but it is not) After zipping a folder, it reports that it is "created in a public folder" (but it is not in such a folder) Oct 12, 2024
@joshtrichards
Copy link
Member

joshtrichards commented Oct 31, 2024

Reproduced.

I believe it's originating from here:

https://github.com/nextcloud/activity/blob/3830230bce3673007cd38477efc0e78eb8eda0b5/lib/FilesHooks.php#L67-L82

EDIT: Maybe be related to recent change:

nextcloud/activity#1745
nextcloud/server#46945

@vapoto
Copy link

vapoto commented Dec 26, 2024

The issue is not specific to the zipper it seems, as I am also getting an email "Cospend/[project_name]_daily_2024-12-25.csv was created in a public folder" since upgrading to NC 30, even though this is not a public folder.

@juliusknorr
Copy link
Member

The issue is that the activity is not aware of the user zipping the file, as we run the zip file creation in a cron job, we need to set the user manually.

I pushed a fix in #304 Testing is very welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants