From 627c7ae516144fe66198eaa4e105a0f86bee7974 Mon Sep 17 00:00:00 2001 From: Louis Chemineau Date: Wed, 5 Jul 2023 15:14:25 +0200 Subject: [PATCH 1/2] Replace "Unselect" with "Unselect all" in right click menu Signed-off-by: Louis Chemineau --- js/files.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/js/files.js b/js/files.js index 216cec7..63bc106 100644 --- a/js/files.js +++ b/js/files.js @@ -59,8 +59,8 @@ if (currentFile.hasClass('selected')) { menu.find('ul').html(''); - addNewOption('Check', 'category-disabled', t(appName, 'Unselect'), function () { - $(currentFile.find('input.selectCheckBox')).click(); + addNewOption('Check', 'category-disabled', t(appName, 'Unselect all'), function () { + currentFile.closest('tbody').find('tr input.selectCheckBox:checked').trigger('click') }); $.each($('.selectedActions:not(.hidden) .menu-center li:not(.hidden)'), function (i, selectedAction) { From b9eb419a9262eb8e075eb170bc2fba2570f50a34 Mon Sep 17 00:00:00 2001 From: Louis Chemineau Date: Thu, 6 Jul 2023 11:08:13 +0200 Subject: [PATCH 2/2] Remove phpunit workflow Signed-off-by: Louis Chemineau --- .github/workflows/phpunit-sqlite.yml | 120 --------------------------- 1 file changed, 120 deletions(-) delete mode 100644 .github/workflows/phpunit-sqlite.yml diff --git a/.github/workflows/phpunit-sqlite.yml b/.github/workflows/phpunit-sqlite.yml deleted file mode 100644 index fc7fdd1..0000000 --- a/.github/workflows/phpunit-sqlite.yml +++ /dev/null @@ -1,120 +0,0 @@ -# This workflow is provided via the organization template repository -# -# https://github.com/nextcloud/.github -# https://docs.github.com/en/actions/learn-github-actions/sharing-workflows-with-your-organization - -name: PHPUnit - -on: - pull_request: - push: - branches: - - main - - master - - stable* - -permissions: - contents: read - -env: - # Location of the phpunit.xml and phpunit.integration.xml files - PHPUNIT_CONFIG: ./tests/phpunit.xml - PHPUNIT_INTEGRATION_CONFIG: ./tests/phpunit.integration.xml - -jobs: - phpunit-sqlite: - runs-on: ubuntu-latest - - strategy: - matrix: - php-versions: ['8.0', '8.1', '8.2'] - server-versions: ['stable26'] - - steps: - - name: Set app env - run: | - # Split and keep last - echo "APP_NAME=${GITHUB_REPOSITORY##*/}" >> $GITHUB_ENV - - - name: Checkout server - uses: actions/checkout@v3 - with: - submodules: true - repository: nextcloud/server - ref: ${{ matrix.server-versions }} - - - name: Checkout app - uses: actions/checkout@v3 - with: - path: apps/${{ env.APP_NAME }} - - - name: Set up php ${{ matrix.php-versions }} - uses: shivammathur/setup-php@v2 - with: - php-version: ${{ matrix.php-versions }} - tools: phpunit - extensions: mbstring, iconv, fileinfo, intl, sqlite, pdo_sqlite - coverage: none - - - name: Check composer file existence - id: check_composer - uses: andstor/file-existence-action@v1 - with: - files: apps/${{ env.APP_NAME }}/composer.json - - - name: Set up PHPUnit - # Only run if phpunit config file exists - if: steps.check_composer.outputs.files_exists == 'true' - working-directory: apps/${{ env.APP_NAME }} - run: composer i - - - name: Set up Nextcloud - env: - DB_PORT: 4444 - run: | - mkdir data - ./occ maintenance:install --verbose --database=sqlite --database-name=nextcloud --database-host=127.0.0.1 --database-port=$DB_PORT --database-user=root --database-pass=rootpassword --admin-user admin --admin-pass password - ./occ app:enable ${{ env.APP_NAME }} - - - name: Check PHPUnit config file existence - id: check_phpunit - uses: andstor/file-existence-action@v1 - with: - files: apps/${{ env.APP_NAME }}/${{ env.PHPUNIT_CONFIG }} - - - name: PHPUnit - # Only run if phpunit config file exists - if: steps.check_phpunit.outputs.files_exists == 'true' - working-directory: apps/${{ env.APP_NAME }} - run: ./vendor/phpunit/phpunit/phpunit -c ${{ env.PHPUNIT_CONFIG }} - - - name: Check PHPUnit integration config file existence - id: check_integration - uses: andstor/file-existence-action@v1 - with: - files: apps/${{ env.APP_NAME }}/${{ env.PHPUNIT_INTEGRATION_CONFIG }} - - - name: Run Nextcloud - # Only run if phpunit integration config file exists - if: steps.check_integration.outputs.files_exists == 'true' - run: php -S localhost:8080 & - - - name: PHPUnit integration - # Only run if phpunit integration config file exists - if: steps.check_integration.outputs.files_exists == 'true' - working-directory: apps/${{ env.APP_NAME }} - run: ./vendor/phpunit/phpunit/phpunit -c ${{ env.PHPUNIT_INTEGRATION_CONFIG }} - - summary: - permissions: - contents: none - runs-on: ubuntu-latest - needs: phpunit-sqlite - - if: always() - - name: phpunit-sqlite-summary - - steps: - - name: Summary status - run: if ${{ needs.phpunit-sqlite.result != 'success' }}; then exit 1; fi