[Bug]: Incorrect use of desktopFileName

[kleifgch]

⚠️ Before submitting, please verify the following: ⚠️

• This is a bug, not a question or a configuration issue.
• This issue is not already reported on Github (I've searched it).
• Nextcloud Server and Desktop Client are up to date. See Server Maintenance and Release Schedule and Desktop Releases for supported versions.
• I agree to follow Nextcloud's Code of Conduct

Bug description

On my system, the Nextcloud client emits the following warning shortly after being started:

QGuiApplication::setDesktopFileName: the specified desktop file name ends with .desktop. For compatibility reasons, the .desktop suffix will be removed. Please specify a desktop file name without .desktop suffix

This seems to be caused by this snippet:

desktop/src/gui/application.cpp

Lines 232 to 234 in ae363c9

	QString desktopFileName = QString(QLatin1String(LINUX_APPLICATION_ID)
	+ QLatin1String(".desktop"));
	setDesktopFileName(desktopFileName);

The documentation for this function has been clarified in qt/qtbase@0c5135a and the detection of the suffix has been introduced in qt/qtbase@fb86c5a

Steps to reproduce

1. Start the Nextcloud client
2. Observe the output

Expected behavior

This warning should not be issued.

Which files are affected by this bug

https://github.com/nextcloud/desktop/blob/ae363c90e907efb8d9610f1f8b84ed4d3484dd84/src/gui/application.cpp

Operating system

Linux

Which version of the operating system you are running.

NixOS unstable

Package

Distro package manager

Nextcloud Server version

28.0.5

Nextcloud Desktop Client version

3.14.3

Is this bug present after an update or on a fresh install?

Fresh desktop client install

Are you using the Nextcloud Server Encryption module?

Encryption is Enabled

Are you using an external user-backend?

• Default internal user-backend
• LDAP/ Active Directory
• SSO - SAML
• Other

Nextcloud Server logs

Additional info

No response

[Dominique-M]

Idem under Debian testing with clientVersion=3.15.0 (build 27049) (Appimage) and serverVersion=29.0.6.1