[Bug]: False warning of duplicate sync connection with parent or child

[viharm]

⚠️ Before submitting, please verify the following: ⚠️

• This is a bug, not a question or a configuration issue.
• This issue is not already reported on Github (I've searched it).
• Nextcloud Server and Desktop Client are up to date. See Server Maintenance and Release Schedule and Desktop Releases for supported versions.
• I agree to follow Nextcloud's Code of Conduct

Bug description

When creating a new sync connection, the Select a remote destination folder pop-up throws a false warning that the requested folder is either a parent or a child of another folder.

Steps to reproduce

1. Add a connection to a path on the server that includes a keyword in the last stub of the path, e.g., /home/user/Nextcloud_Test.
2. then add another connection on the server that has the exact keyword as the last stub of the path, e.g., /home/user/Nextcloud.

Expected behavior

The client should should not emit a warning

Which files are affected by this bug

Not sure

Operating system

Windows

Which version of the operating system you are running.

Windows 11

Package

Other

Nextcloud Server version

28.0.8

Nextcloud Desktop Client version

3.13.2

Is this bug present after an update or on a fresh install?

Fresh desktop client install

Are you using the Nextcloud Server Encryption module?

Encryption is Disabled

Are you using an external user-backend?

• Default internal user-backend
• LDAP/ Active Directory
• SSO - SAML
• Other

Nextcloud Server logs

No response

Additional info

The destination path on the server is mapped to a SSH storage backend.

[joshtrichards]

I guess we need to add a trailing slash to dir for the startsWith() check:

desktop/src/gui/folderwizard.cpp

Lines 485 to 512 in 14a5dd1

	bool FolderWizardRemotePath::isComplete() const
	{
	if (!_ui.folderTreeWidget->currentItem())
	return false;
	QStringList warnStrings;
	QString dir = _ui.folderTreeWidget->currentItem()->data(0, Qt::UserRole).toString();
	if (!dir.startsWith(QLatin1Char('/'))) {
	dir.prepend(QLatin1Char('/'));
	}
	wizard()->setProperty("targetPath", dir);
	Folder::Map map = FolderMan::instance()->map();
	Folder::Map::const_iterator i = map.constBegin();
	for (i = map.constBegin(); i != map.constEnd(); i++) {
	auto *f = static_cast<Folder *>(i.value());
	if (f->accountState()->account() != _account) {
	continue;
	}
	QString curDir = f->remotePathTrailingSlash();
	if (QDir::cleanPath(dir) == QDir::cleanPath(curDir)) {
	warnStrings.append(tr("This folder is already being synced."));
	} else if (dir.startsWith(curDir)) {
	warnStrings.append(tr("You are already syncing <i>%1</i>, which is a parent folder of <i>%2</i>.").arg(Utility::escape(curDir), Utility::escape(dir)));
	} else if (curDir.startsWith(dir)) {
	warnStrings.append(tr("You are already syncing <i>%1</i>, which is a subfolder of <i>%2</i>.").arg(Utility::escape(curDir), Utility::escape(dir)));
	}
	}

[camilasan]

We have fixed this with #7636 and #7596.