Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine sharing / activity as "file detail" #3845

Closed
tobiasKaminsky opened this issue Sep 30, 2021 · 3 comments · Fixed by #4929
Closed

Combine sharing / activity as "file detail" #3845

tobiasKaminsky opened this issue Sep 30, 2021 · 3 comments · Fixed by #4929
Assignees

Comments

@tobiasKaminsky
Copy link
Member

tobiasKaminsky commented Sep 30, 2021

Would it be possible that we combine the window for Sharing and Activity into one, with tabs? Then it would be just like on web and Android/iOS.

Clicking the "Sharing" action anywhere would always open the window with the sharing tab open, and "View activity" would open the window with the "Activity" tab open.

cc @tobiasKaminsky since it’s regarding cross-platform experience.

Originally posted by @jancborchardt in #3737 (comment)

@tobiasKaminsky
Copy link
Member Author

New file activity:
image

Sharing dialog is well known :)

If something is not clear, please discuss it with designers (maybe even with mockup), before working on it :)

@claucambra
Copy link
Collaborator

This will not be possible unless we rewrite the share dialog in QML (which I think we should do, as we should with the Settings dialog). This does mean it will be a lot more work though

@tobiasKaminsky I am happy to take this task

@claucambra
Copy link
Collaborator

Notes from design call:

  • Mockup at 🤝 Improvement to sharing design and flow server#26691

  • Combine into File details dialog (like sidebar on web)

  • Is its own dialog first, like now, but QML

  • Then afterwards we can also integrate it into the tray menu, cause then you could click on the menu of activity list entries and the details can slide in

@tobiasKaminsky tobiasKaminsky moved this to 🧭 Planning evaluation (dont pick) in 🤖 🍏 Mobile clients team Aug 18, 2022
@tobiasKaminsky tobiasKaminsky moved this from 🧭 Planning evaluation (dont pick) to 🏗️ In progress in 🤖 🍏 Mobile clients team Aug 18, 2022
@tobiasKaminsky tobiasKaminsky moved this from 🏗️ In progress to 📄 To do (~10 entries) in 🤖 🍏 Mobile clients team Sep 8, 2022
@tobiasKaminsky tobiasKaminsky moved this from 📄 To do (~10 entries) to ☑️ Done in 🤖 🍏 Mobile clients team Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

3 participants