Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "Choose" button for the color picker doesn't seem to do anything #6651

Open
RayBB opened this issue Jan 9, 2025 · 3 comments
Open

The "Choose" button for the color picker doesn't seem to do anything #6651

RayBB opened this issue Jan 9, 2025 · 3 comments

Comments

@RayBB
Copy link

RayBB commented Jan 9, 2025

How to use GitHub

  • Please use the 👍 reaction to show that you are affected by the same issue.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Describe the bug
When I select a list's color and press "Choose" nothing happens except unfocusing from the color I picked.

To Reproduce
Steps to reproduce the behavior:

  1. Open sidebar
  2. Click the three dots next to a list
  3. Click edit list
  4. Click the color picker
  5. Click on a color
  6. Click Choose

Expected behavior
The color is set and the popup closes

Screenshots
Image

PS: The color of the list is also slightly obscured, perhaps a different issue.
Image

Client details:

  • OS: [e.g. iOS] Mac+Android
  • Browser [e.g. chrome, safari] FF (both
  • Version [e.g. 22] Deck 1.13.3
  • Device: [e.g. iPhone6, desktop] Macbook Pro and Pixel 7
Server details I don't think this is really relevant since the issue is a small client side bug.

Operating system:

Web server:

Database:

PHP version:

Nextcloud version: (see Nextcloud admin page)

Where did you install Nextcloud from:

Signing status:

Login as admin user into your Nextcloud and access
http://example.com/index.php/settings/integrity/failed
paste the results here.

List of activated apps:

If you have access to your command line run e.g.:
sudo -u www-data php occ app:list
from within your Nextcloud installation folder

Nextcloud configuration:

If you have access to your command line run e.g.:
sudo -u www-data php occ config:list system
from within your Nextcloud installation folder

or

Insert your config.php content here
Make sure to remove all sensitive content such as passwords. (e.g. database password, passwordsalt, secret, smtp password, …)

Are you using an external user-backend, if yes which one: LDAP/ActiveDirectory/Webdav/...

Logs

Nextcloud log (data/nextcloud.log)

N/A

Browser log

No relevant logs seen in the browser

@luka-nextcloud
Copy link
Contributor

I can reproduce this issue on v28, v29, v30 and master.

I think we need to discuss how to fix it - there are 2 ways:

  • Clicking "Choose" button should close the color select pane and does nothing, update api should be called by clicking the save button
  • Clicking "Choose" button should close the color select pane and also call the update api to reflect the selected color

I would suggest just to close the color pane and do nothing when we click the "Choose" button.

@RayBB
Copy link
Author

RayBB commented Jan 14, 2025

Personally I think the first one seems more intuitive but either fix would be great

@juliusknorr
Copy link
Member

nextcloud-libraries/nextcloud-vue#6336 passed by earlier today.

@luka-nextcloud Maybe you can check if that fixes it already?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants