Release tarball for 2.16.0 contains vim temp files

[darix]

Download taken from https://apps.nextcloud.com/apps/collectives

tar tf *gz | rg '\.swp'
collectives/.Makefile.sw

and due to the signing it will now cause errors from deleting the file.

[juliusknorr]

@max-nextcloud any clue why?

On other apps if built with krankerl it would to the build in a fresh clone, maybe worth to adapt for collectives as well

[max-nextcloud]

We have a git status --porcelain check that did not get triggered by the file because .*.swp is in my users .gitignore.

We also rsync the files to a separate directory to make sure only the files we want are included - however that excludes the pattern .[a-z]* - which does not match .Makefile.swp. I'll exclude .** - we currently don't have any hidden directories we'd want to include.

[darix]

you must have had the Makefile open in vim open before rsync.

[max-nextcloud]

I fixed the Makefile so the build can handle dangling hidden files. Will release 2.16.1 once

• fix(build): exclude all hidden files and folders #1649
  is merged.

[darix]

that commit wont catch .swp files in subdirectories :)

[max-nextcloud]

If we extended the expression to exclude hidden files in subfolders the following files would also be excluded:

./build/release/collectives/vendor/teamtnt/tntsearch/.travis.yml
./build/release/collectives/vendor/teamtnt/tntsearch/.gitignore
./build/release/collectives/vendor/teamtnt/tntsearch/.github
./build/release/collectives/vendor/teamtnt/tntsearch/tests/_files/mnist/.gitignore
./build/release/collectives/l10n/.gitkeep

I don't think we'd miss them. Actually teamtnt seems to be quite permissive with respect to including files in its releases.

[darix]

my complaint wasnt with dotfiles in general. but opensuse has a packaging check for *.swp *~

you know the usual tmp files. it is usually to protect us from ourself. but sometimes we also catch upstream with the check :)