Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace character key shortcuts #4366

Open
JuliaKirschenheuter opened this issue Jul 13, 2022 · 3 comments
Open

Replace character key shortcuts #4366

JuliaKirschenheuter opened this issue Jul 13, 2022 · 3 comments
Labels
1. to develop Accepted and waiting to be taken care of enhancement New feature request

Comments

@JuliaKirschenheuter
Copy link
Contributor

JuliaKirschenheuter commented Jul 13, 2022

Is your feature request related to a problem? Please describe.

Accessibility issue.

There are keyboard shortcuts for activating different functions in the Calendar app. Shortcuts such as these can interfere with shortcuts used by some assistive technologies.

image

Because of this the character key shortcuts should be replaced.

Suggested solution

  • Give an option to turn off keyboard shortcuts
  • Set them to only be active when the user is in the area they affect
  • Test so the shortcuts don’t interfere with screen reader commands

Please make sure that the shortcuts don’t interfere with screen reader commands (NVDA, Jaws, Orca).

See more here
https://www.w3.org/TR/WCAG21/#character-key-shortcuts
https://webtest.bitv-test.de/index.php?a=di&iid=269&s=n

Describe the solution you'd like

No response

Describe alternatives you've considered

No response

Additional context

No response

@JuliaKirschenheuter JuliaKirschenheuter added 1. to develop Accepted and waiting to be taken care of enhancement New feature request labels Jul 13, 2022
@nickvergessen
Copy link
Member

nickvergessen commented Sep 14, 2022

Server PR for a global setting to opt out of keyboard shortcuts to satisfy accessibility is in:

Method to check: OCP.Accessibility.disableKeyboardShortcuts()

If that is true the app(s) must not register ANY shortcuts.

@szaimen
Copy link
Contributor

szaimen commented Sep 14, 2022

If that is true the app(s) must not register ANY shortcuts.

I disagree. Shortcuts with modifier key and probably also ESC are always okay IIRC.

cc @jancborchardt

@nickvergessen
Copy link
Member

I disagree. Shortcuts with modifier key and probably also ESC are always okay IIRC.

This was the outcome of the accessibility review. We have a global setting which disables everything and done.
It heavily depends on the screenreader and tools that you use if Ctrl and/or Alt or other things are okay to use or not. And since maintaining a more detailed list is too much effort, we have a global on/off

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of enhancement New feature request
Projects
None yet
Development

No branches or pull requests

3 participants