Beta20161224: files don't get downloaded properly when SD card storage is selected

[elpraga]

Actual behaviour

When external storage is selected, files fail to download. They do get downloaded to the tmp folder in the main storage, but they don't get transferred to the SD card and download ends with Failed message.

Expected behaviour

Files should get downloaded to the SD card

Steps to reproduce

1. Set SD card as the storage
2. Try to download a file.

Environment data

Android version: 6.0

Device model: Huawei Y6II

Stock or customized system:
Stock

[AndyScherzinger]

Hi @elpraga do you see any error regarding it in the clients log?

[elpraga]

I don't know anything about Android apps, but I just noticed there is a mention to com.android.owncloud...

I also have the official ownCloud (not nextCloud) app installed.

[AndyScherzinger]

The error seems to be this line:

DownloadFileOperation : Download of /Documentos/España/Sevilla/Librería/IMG_20161202_143246.jpg to /storage/D805-1DED/Android/data/com.nextcloud.android.beta/files/nextcloud/tomas@elpraga.no-ip.biz%3A1943%2Fowncloud/Documentos/España/Sevilla/Librería/IMG_20161202_143246.jpg: Error while moving file to final directory

can you check if you have the following folder structure on your device:

/storage/D805-1DED/Android/data/com.nextcloud.android.beta/files/nextcloud/tomas@elpraga.no-ip.biz%3A1943%2Fowncloud/

which would then be the apps file root folder.

[elpraga]

This might be the preferable way to add the log I guess..

currentLog.txt

[elpraga]

Yes @AndyScherzinger I do. In fact when I move manually the files to the location in SD card, I can see them in the application without any problems.

[elpraga]

Maybe some issues with writing to the SD card. Could the broadcast to com.android.owncloud... Be the cause?

Please let me know if I can add other useful info..

[elpraga]

It just occurred to me that the escape characters might cause done problems, but I just tried

cd /storage/D805-1DED/Android/data/com.nextcloud.android.beta/files/nextcloud/tomas@elpraga.no-ip.biz%3A1943%2Fowncloud/

in a terminal and I got there without any problems

[elpraga]

Two observations:

1

The application does create the appropriate folder structure on the SD card.

2

The temp file is located in
/storage/emulated/0/nextcloud/tmp

But the log is located in
/storage/emulated/0/nextcloudbeta/log

Could it be possible that the app is trying to copy the file from a wrong direction (expecting it to be in the nextcloudbeta folder)?

What do you think @AndyScherzinger ?

[AndyScherzinger]

ooooouuh.... Yeah, my guess would be that it should be /storage/emulated/0/nextcloudbeta/tmp What do you think @tobiasKaminsky @przybylski ?

[elpraga]

Thinking about it a little bit more.. shouldn't the tmp directory be located on the SD card as well, when SD card is selected as the storage path? The current solution might bring a surprise when you're his try to download a large file with not enough space on the internal storage, but plenty of free space on the SD card.

Is there any real reason for the temp directory being on the internal storage?

[elpraga]

Can you reproduce the error?

[OlivierS1]

Having same issue with Nextcloud Beta 20161231.
Storage on SD card.
Some files gets downloaded if I select them once at a time, but as soon as I select the upper folder and do "Synchronize" then downloads start failing.
I am not certain this step is what's causing the issue though.

[elpraga]

I upgraded my server to NC11 and downloaded NC android app.

I can confirm that downloading files con NC official app work fine even when SD card storage is selected.

The app also uses SD card to store the tmp files.

Maybe just some mismatch when building the Beta app?

[elpraga]

@tobiasKaminsky were you able to reproduce this? I would guess you use the files on SD card as well..

[OlivierS1]

Nextcloud Beta 20170111 broke SD card download again.
It seems it was working fine with 20170106 or 20170109.

[elpraga]

Are there any news regarding this issue?

[AndyScherzinger]

Not yet. Tobias is on vacation and I am ill which completely knocks me out at the moment :(

[elpraga]

Ahh. Get well soon then! 👍 ;-)

[elpraga]

Beta20170122 still fails to download files correctly. Were you able to identify why @tobiasKaminsky?

[tobiasKaminsky]

Sorry currently I do not have a device with an external sdcard.
@mario do you have such a device?

[elpraga]

@tobiasKaminsky the issue seems to be that when the SD card is selected as storage, the BETA app still creates the tmp directory in the main storage. I assume that is en error, and then the app searches for the tmp file on the SD card and doesn't find it. Hance it reports an error.

If you were willing just like look into this behavior, I'll be willing to test it then..

[mario]

@tobiasKaminsky I'll take a look cc @elpraga, I do have such a device.

[bekl101]

still the same problem in beta 20170206. App logs in directory "nextcloudbeta" and the temporary file resides in "nextcloud" at internal storage. No file can be stored in the selected directory at the SD-Card.
download crashes.

[bekl101]

tested with beta 20170208, same behavior as described above. (SGS7 Android 7.0 VD2)

[mario]

@bekl101 I didn't touch this part and it's unlikely I'll be able to touch it for 1.4.2 :( Maybe later - sorry!

[bekl101]

@mario
doesn´t matter.
i wonder because this function was ok in the stable release.

[mario]

Well, that is strange then ... @AndyScherzinger any more insights since you last wrote here? :)

[elpraga]

@mario I can confirm that it is working in the stable release. In my opinion, it is a mishap with the paths where temp files are created. The Beta app most likely creates the tmp file somewhere and looks for it somewhere else.

I guess it should be very easy to fix just by checking where the tmp file is created when SD card is selected as storage (it should be created on the SD card, not in the main storage).

It would be great if you could have a look at it soon (at least a quick one to see if it is really as simple to fix as I think), because it is extremely inconvenient not to be able to download the files properly. Between the stable app that is slow as it has to redownload the previews over and over again due to small cache size and this error, it is much more difficult to access the files on the server than it was before.

[mario]

@elpraga I wonder if the issue is specific to the beta app ... maybe once we release this'll automagically work :)

But ok, I'll try to check.

[bekl101]

i agree with elpraga
it seems not to be an issue which is specific for an android version becaus he uses 6.0 and my mobile has 7.0.
Maybe only typo or little mismatch or only the word "beta" in app and filepath
in my opinion its ab big restriction for me too.

[tobiasKaminsky]

@przybylski can you shed us some light here? :)

[mario]

@tobiasKaminsky I fixed this. The issue was only in beta because some things weren't merged properly ages ago. Whenever we build new beta (tomorrow?) this will be fixed! Thank you @bekl101 and @elpraga for the patience!

[elpraga]

That would be great news @mario ! Thank you so much! I will confirm that it is working as soon as you release a new beta.

[bekl101]

@mario
i agree with elpraga. Good news. I will test it too.

[mario]

@bekl101 @elpraga should be here: https://github.com/nextcloud/android/raw/beta/apks/latest.apk

[bekl101]

Only a short review. Download latest.apk, fresh install.
Selected files were transfered correct fom NC to SD-Card on my phone.
No error or other issues i can see for now.
Very good work. thanks

[elpraga]

Great @mario ! The second Beta20170213 is working again! Files can be downloaded! Thanks a lot mate! 😄 👍

[mario]

Glad it's working for you folks! ;)