Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provider authorities should be an absolute package name #129

Closed
AndyScherzinger opened this issue Jul 14, 2016 · 4 comments
Closed

Provider authorities should be an absolute package name #129

AndyScherzinger opened this issue Jul 14, 2016 · 4 comments

Comments

@AndyScherzinger
Copy link
Member

AndyScherzinger commented Jul 14, 2016

As already filed in the owncloud issue tracker owncloud/android#1735 forks will have collisions with authorities, e.g. UsersAndGroupsSearchProvider as well as the ManageSpaceActivity.

The later has been fixed (for us) by using the full qualified name of the class but I think it would be best, if we move these two (and any other that may need to be moved) to a com.nextcloud.android package so both apps behave well and let a user run them in parallel - being good citizens.

cc for approval: @nextcloud/android

@jancborchardt
Copy link
Member

Sounds good, yeah.

@przybylski
Copy link
Member

ok to me

@AndyScherzinger
Copy link
Member Author

Sweet let's when we find the time to do this. We either can get it into 1.2.0 or should maybe do a 1.2.1 depending on how long it'll take us to implement 1.3.0

@AndyScherzinger AndyScherzinger added this to the Nextcloud App 1.2.0 milestone Jul 18, 2016
tobiasKaminsky added a commit that referenced this issue Jul 18, 2016
@tobiasKaminsky
Copy link
Member

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants