From cd4bdf63813666f5dcea722e8f3b688a503a4109 Mon Sep 17 00:00:00 2001
From: "Grigorii K. Shartsev" <me@shgk.me>
Date: Mon, 27 Jan 2025 15:50:28 +0100
Subject: [PATCH 1/3] fix(NcEmojiPicker): arrow navigation

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
---
 .../NcEmojiPicker/NcEmojiPicker.vue           | 32 +++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/src/components/NcEmojiPicker/NcEmojiPicker.vue b/src/components/NcEmojiPicker/NcEmojiPicker.vue
index 52480cb40e..1d7d08527c 100644
--- a/src/components/NcEmojiPicker/NcEmojiPicker.vue
+++ b/src/components/NcEmojiPicker/NcEmojiPicker.vue
@@ -147,6 +147,11 @@ This component allows the user to pick an emoji.
 						trailing-button-icon="close"
 						:trailing-button-label="t('Clear search')"
 						:show-trailing-button="search !== ''"
+						@keydown.left="callPickerArrowHandlerWithScrollFix('onArrowLeft', $event)"
+						@keydown.right="callPickerArrowHandlerWithScrollFix('onArrowRight', $event)"
+						@keydown.down="callPickerArrowHandlerWithScrollFix('onArrowDown', $event)"
+						@keydown.up="callPickerArrowHandlerWithScrollFix('onArrowUp', $event)"
+						@keydown.enter="$refs.picker.onEnter"
 						@trailing-button-click="clearSearch(); slotProps.onSearch(search);"
 						@update:value="slotProps.onSearch(search)" />
 					<NcColorPicker palette-only
@@ -432,6 +437,33 @@ export default {
 				focusableList[last].focus()
 			}
 		},
+
+		/**
+		 * Handle arrow navigation via <Picker>'s handlers with scroll bug fix
+		 * @param {'onArrowLeft' | 'onArrowRight' | 'onArrowDown' | 'onArrowUp'} originalHandlerName - Picker's arrow keydown handler name
+		 * @param {KeyboardEvent} event - Keyboard event
+		 */
+		async callPickerArrowHandlerWithScrollFix(originalHandlerName, event) {
+			// Call the original handler
+			// See: https://github.com/serebrov/emoji-mart-vue/blob/a1ea72673a111cce78dc8caad8bc9ea3e02ad5bd/src/components/Picker.vue#L29
+			// TODO: expose these methods via slot props in upstream library
+			this.$refs.picker[originalHandlerName](event)
+
+			// Wait until emoji-mart-vue-fast scrolls
+			await this.$nextTick()
+
+			// Scroll position is incorrect after emoji-mart-vue-fast scrolls...
+			// It calculates scroll incorrectly.
+			// It doesn't take into account, that emojis are wrapped into categories sections
+			// See: https://github.com/serebrov/emoji-mart-vue/blob/a1ea72673a111cce78dc8caad8bc9ea3e02ad5bd/src/utils/picker.js#L244
+			// Now scroll to the correct position
+			// TODO: fix in upstream
+			const selectedEmoji = this.$refs.picker.$el.querySelector('.emoji-mart-emoji-selected')
+			selectedEmoji?.scrollIntoView({
+				block: 'center',
+				inline: 'center',
+			})
+		},
 	},
 }
 </script>

From 16c596f396dd9add97f21d5834a4dfd181928928 Mon Sep 17 00:00:00 2001
From: "Grigorii K. Shartsev" <me@shgk.me>
Date: Mon, 27 Jan 2025 16:50:17 +0100
Subject: [PATCH 2/3] fix(NcEmojiPicker): skip emoji on Tab navigation

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
---
 .../NcEmojiPicker/NcEmojiPicker.vue           | 56 +++++++------------
 1 file changed, 21 insertions(+), 35 deletions(-)

diff --git a/src/components/NcEmojiPicker/NcEmojiPicker.vue b/src/components/NcEmojiPicker/NcEmojiPicker.vue
index 1d7d08527c..5366dc0ae8 100644
--- a/src/components/NcEmojiPicker/NcEmojiPicker.vue
+++ b/src/components/NcEmojiPicker/NcEmojiPicker.vue
@@ -107,10 +107,12 @@ This component allows the user to pick an emoji.
 </docs>
 
 <template>
-	<NcPopover :shown.sync="open"
+	<NcPopover ref="popover"
+		:shown.sync="open"
 		:container="container"
 		popup-role="dialog"
 		v-bind="$attrs"
+		:focus-trap="false /* Handled manually to remove emoji buttons from TAB sequence */"
 		v-on="$listeners"
 		@after-show="afterShow"
 		@after-hide="afterHide">
@@ -135,6 +137,7 @@ This component allows the user to pick an emoji.
 			aria-modal="true"
 			:aria-label="t('Emoji picker')"
 			v-bind="$attrs"
+			@keydown.native.tab.prevent="handleTabNavigationSkippingEmojis"
 			@select="select">
 			<template #searchTemplate="slotProps">
 				<div class="search__wrapper">
@@ -396,45 +399,28 @@ export default {
 		},
 
 		afterShow() {
-			// add focus trap in modal
-			const picker = this.$refs.picker
-			picker.$el.addEventListener('keydown', this.checkKeyEvent)
-
-			// set focus on input search field
-			const input = this.$refs.search?.$refs.inputField?.$refs.input
-			if (input) {
-				input.focus()
-			}
+			this.$refs.search.focus()
 		},
 
 		afterHide() {
-			// remove keydown listner if popover is hidden
-			const picker = this.$refs.picker
-			picker.$el.removeEventListener('keydown', this.checkKeyEvent)
+			// Manually return focus to the trigger button, as we disabled focus-trap
+			this.$refs.popover.$el.querySelector('button, [role="button"]')?.focus()
 		},
 
-		checkKeyEvent(event) {
-			if (event.key !== 'Tab') {
-				return
-			}
-			const picker = this.$refs.picker
-			const focusableList = picker.$el.querySelectorAll(
-				'button, input',
-			)
-			const last = focusableList.length - 1
-			// escape early if only 1 or no elements to focus
-			if (focusableList.length <= 1) {
-				event.preventDefault()
-				return
-			}
-			if (event.shiftKey === false && event.target === focusableList[last]) {
-				// Jump to first item when pressing tab on the latest item
-				event.preventDefault()
-				focusableList[0].focus()
-			} else if (event.shiftKey === true && event.target === focusableList[0]) {
-				// Jump to the last item if pressing shift+tab on the first item
-				event.preventDefault()
-				focusableList[last].focus()
+		/**
+		 * Manually handle Tab navigation skipping emoji buttons.
+		 * Navigation over emojis is handled by Arrow keys.
+		 * @param {KeyboardEvent} event - Keyboard event
+		 */
+		handleTabNavigationSkippingEmojis(event) {
+			const current = event.target
+			const focusable = Array.from(this.$refs.picker.$el.querySelectorAll('button:not(.emoji-mart-emoji), input'))
+			if (!event.shiftKey) {
+				const nextNode = focusable.find((node) => current.compareDocumentPosition(node) & Node.DOCUMENT_POSITION_FOLLOWING) || focusable[0]
+				nextNode.focus()
+			} else {
+				const prevNode = focusable.findLast((node) => current.compareDocumentPosition(node) & Node.DOCUMENT_POSITION_PRECEDING) || focusable.at(-1)
+				prevNode.focus()
 			}
 		},
 

From 8ad100640a0ff40e541ea18e8c41e18c81e6b950 Mon Sep 17 00:00:00 2001
From: "Grigorii K. Shartsev" <me@shgk.me>
Date: Mon, 27 Jan 2025 17:17:42 +0100
Subject: [PATCH 3/3] refactor(NcEmojiPicker): simplify clear button

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
---
 .../NcEmojiPicker/NcEmojiPicker.vue           | 27 ++++++++-----------
 1 file changed, 11 insertions(+), 16 deletions(-)

diff --git a/src/components/NcEmojiPicker/NcEmojiPicker.vue b/src/components/NcEmojiPicker/NcEmojiPicker.vue
index 5366dc0ae8..456e81790e 100644
--- a/src/components/NcEmojiPicker/NcEmojiPicker.vue
+++ b/src/components/NcEmojiPicker/NcEmojiPicker.vue
@@ -139,7 +139,7 @@ This component allows the user to pick an emoji.
 			v-bind="$attrs"
 			@keydown.native.tab.prevent="handleTabNavigationSkippingEmojis"
 			@select="select">
-			<template #searchTemplate="slotProps">
+			<template #searchTemplate="{ onSearch }">
 				<div class="search__wrapper">
 					<NcTextField ref="search"
 						class="search"
@@ -155,8 +155,8 @@ This component allows the user to pick an emoji.
 						@keydown.down="callPickerArrowHandlerWithScrollFix('onArrowDown', $event)"
 						@keydown.up="callPickerArrowHandlerWithScrollFix('onArrowUp', $event)"
 						@keydown.enter="$refs.picker.onEnter"
-						@trailing-button-click="clearSearch(); slotProps.onSearch(search);"
-						@update:value="slotProps.onSearch(search)" />
+						@trailing-button-click="clearSearch(); onSearch('');"
+						@update:value="onSearch(search)" />
 					<NcColorPicker palette-only
 						:container="container"
 						:palette="skinTonePalette"
@@ -359,10 +359,7 @@ export default {
 
 		clearSearch() {
 			this.search = ''
-			const input = this.$refs.search?.$refs.inputField?.$refs.input
-			if (input) {
-				input.focus()
-			}
+			this.$refs.search.focus()
 		},
 
 		/**
@@ -575,15 +572,13 @@ export default {
 </style>
 
 <style scoped lang="scss">
-.search {
-	&__wrapper {
-		display: flex;
-		flex-direction: row;
-		gap: var(--default-grid-baseline);
-		align-items: end;
-		padding-block: var(--default-grid-baseline);
-		padding-inline: calc(2 * var(--default-grid-baseline));
-	}
+.search__wrapper {
+	display: flex;
+	flex-direction: row;
+	gap: var(--default-grid-baseline);
+	align-items: end;
+	padding-block: var(--default-grid-baseline);
+	padding-inline: calc(2 * var(--default-grid-baseline));
 }
 
 .row-selected {