Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v8.x] NcNavigationNewItem: Is this an accident? #5159

Closed
marcelklehr opened this issue Jan 28, 2024 · 7 comments · Fixed by #5194
Closed

[v8.x] NcNavigationNewItem: Is this an accident? #5159

marcelklehr opened this issue Jan 28, 2024 · 7 comments · Fixed by #5194
Labels
1. to develop Accepted and waiting to be taken care of bug Something isn't working regression Regression of a previous working feature
Milestone
8.6.1

Comments

@marcelklehr
Copy link
Contributor

image

This looks terrible in the Navigation bar, imo.
@raimund-schluessler
Copy link
Contributor

Yes, this is definitely a regression.

@raimund-schluessler raimund-schluessler added bug Something isn't working 1. to develop Accepted and waiting to be taken care of regression Regression of a previous working feature labels Jan 31, 2024
@raimund-schluessler raimund-schluessler added this to the 8.6.1 milestone Jan 31, 2024
@raimund-schluessler
Copy link
Contributor

Could be related to #4730.

@raimund-schluessler
Copy link
Contributor

@szaimen Could you have a look, please? It seems like not all review comments in #4730 got resolved before merging.

@szaimen
Copy link
Contributor

szaimen commented Jan 31, 2024

This didnt break in #4730. See https://deploy-preview-4730--nextcloud-vue-components.netlify.app/#/Components/App%20containers/NcAppNavigation?id=ncappnavigationnewitem and
image

@szaimen
Copy link
Contributor

szaimen commented Jan 31, 2024

So not sure what caused this...

@raimund-schluessler
Copy link
Contributor

Indeed, the preview looked fine. Weird.

@raimund-schluessler
Copy link
Contributor

Seems like it was me 🙈 in #4989, sorry. I will double-check and provide a PR.

@raimund-schluessler raimund-schluessler linked a pull request Jan 31, 2024 that will close this issue
fix(NcAppNavigationNewItem): bring back correct CSS class #5194
Merged
@raimund-schluessler raimund-schluessler mentioned this issue Jan 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1. to develop Accepted and waiting to be taken care of bug Something isn't working regression Regression of a previous working feature
Projects
None yet
Milestone
8.6.1
Development

Successfully merging a pull request may close this issue.

fix(NcAppNavigationNewItem): bring back correct CSS class nextcloud-libraries/nextcloud-vue
3 participants
@marcelklehr @raimund-schluessler @szaimen