From 9d3fe51ed90b760605212212a0901baad6100320 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Raimund=20Schl=C3=BC=C3=9Fler?= Date: Sat, 23 Dec 2023 11:01:30 +0100 Subject: [PATCH] fix(NcAppNavigationItem): adjust tests to cover active prop MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Raimund Schlüßler --- ...em-primary-on-active-entry-menu-active.png | Bin 0 -> 4246 bytes ...NavigationItem-primary-on-active-entry.png | Bin 0 -> 2409 bytes ...vigationItem-tertiary-non-active-entry.png | Bin 0 -> 801 bytes cypress/visual/AppNavigationItem.cy.ts | 23 +++++++++++++++++- 4 files changed, 22 insertions(+), 1 deletion(-) create mode 100644 cypress/snapshots/base/AppNavigationItem.cy.ts/NcAppNavigationItem-primary-on-active-entry-menu-active.png create mode 100644 cypress/snapshots/base/AppNavigationItem.cy.ts/NcAppNavigationItem-primary-on-active-entry.png create mode 100644 cypress/snapshots/base/AppNavigationItem.cy.ts/NcAppNavigationItem-tertiary-non-active-entry.png diff --git a/cypress/snapshots/base/AppNavigationItem.cy.ts/NcAppNavigationItem-primary-on-active-entry-menu-active.png b/cypress/snapshots/base/AppNavigationItem.cy.ts/NcAppNavigationItem-primary-on-active-entry-menu-active.png new file mode 100644 index 0000000000000000000000000000000000000000..c3d11a4ac49951ec6478a296ca9de812a1a40bc7 GIT binary patch literal 4246 zcmXw7byyVd7A6*5q!tAi31Ov68l{$H#U%xH=|(yQq(SLgWa*GvY7qoMN`W6BjnW8G zf=IV?D#9Ip_ufC|duEj%|2UJoUMJVhWYGdWGH<KaBP8|0hlwAjbqofab!(}j!$_Gk zcl^Sg5&SQ`+PO{MqtH0WqJ=nC?smXdK$aj+5f(32zt6NT6$iYEjk zz*vNZYk5b{Y$o1xi+pP$Cqe;V@8w01@T?s^KBa^|8MF*?q>fnDEzv2}OSlPPt49ta z+#==}+ccFC!xsb)2wVXXhwyNakf-QQVDwDYG^()m{Ybqad`xnV1iPFGm}xW0)zvPL zm!$>KoU*0-Wll5T=EFaa$N`5^ul6gv0#_u6C$NbJ69$yY!I022o{AD%pXaw5ldFB# z@QtS}mkfhMP`Ns_&n~~krCz0UZejqp&fh3?6ZhJQ22jp971Nl3B(^GP*Xng%pYSvfxTb!v9 zvW?rqQ5vgXXS=C42Cj>t^6EYyX<1kX>V5{Q85uG1^77Kr)8}J8L{ykIF8un1D=y}S z!{M^O*9rwF_pOZ(LC6PPmE2MkseZZ>V+Tu__OpL~boAeaC#eo3$isYyDk!)Y$1K&J$gZSCc~|!JgIV7&vu6J)r{h9_ z>8w_MbdNH&w}0h@Z<4lOy6>NcDB94?wfc~xUdF(K72=T~p8RIAKTKC?T?nIr&!y^{ z<(HP;FgKUS`>ilhK zeSSeJj;!?B)N5~VAGWV;Ivip3JsN9SSX>M%E93X}_Ab$J=^7lQ*4Ni>YHrSu^}G4; z3RQeGX^7*H<@^RPm%#q>F^i`Z9vvNMW=ft$gU?a`Z(UE{bWpHUJ-)%vo&OC)M zt+&#db#)IYp!W&Y)k%+E-G&ueXZx`FdsY=2-t1#{z;_nteETM{*UTjSt|` zD(qBL8ylQLJ1TkXXUE>C#MiH*+bx9iFouj_ZNc|oFygL9Co^4Mgw6$(9$k!O&&Y*g z|6n*J9V6qr%LPh@OMy4+Q$`Nx&aSTf-QC^18es;?k_$No%4`4HaW1bl(X==NO@IY{ zln!a5?d{zT)!{4ysN%=&>m!_W)YQ}^I%#j5CMtOL4-U|iYqcgy|9#yIsYi=Z^~4}` z9I0~#oZdI1tgSh4&d$zm9veHhd8L8w!)v~dh zbaaYZS`e$xaW+RAV~4+{(@C#W=V83SSi@AE@!dw;XNKWsiYm44VN=(rDP_b6UriK^ z#T0|Nq$Uf>16aDNMLzX2O9zjiF8pB~=Cm%-$D&{FsI!BO`lf^dTmhThmgU zaeb@|It2eCP-8oQEE^jsX==*WEz_$Cx(tkoiE(pxzdB2Qu6!<2&zCQ34<9nf%ggJO zmW6{rD~IvgQnJn4!i~1qX&bF6J1$RHmu_bXQ^1H7)S8>PiJ{Fbqoi_`H6x;af6t$$8k93xAR)aX(EzzfVZyYes5%dSOXP$sEvW9NgRo8)ffDN-8T8WVY+W ziqz5zCN`yfwwYa9{z`HsW4m5K3rot%tiIPeWXlDl`5ml?ShN!D@9!(CsV$;LMn{4A zh6xKNr1I4Hjq5J>9)p{NMxmEIEczYWibyOz4a zr;v4annkhZQtl_j5qwJs_q4N=NAy*%y-3JZ__^RUUf7ZXX}~HDNu)Wm+PjkcQ_SnY zy+8k-io2%nk0o+aaX2af7~wG+8;(gyNd`5xR2mu@{TX6WsOgU`R={O#XJ;jvQS$!Z zbnov!XJ%%O#^H+WhVUQ|$W06&3Plu3^x4eA_Kpr(WFF>kN?uWW_wT*vD2h6akztsz zzS5`Dj^tQhxtN29qT1Nj>^IIaZR4taoo(AZ-W=A#SN^Ejm5pL_jWz8EU+o!0t-)7e z5YA9<2)F=6WC z&d;rh@3a;baTwtUhm`2BsDKrkQ_f|+Hh5MoKDVK2xqU4x1UPDSP0il^zU9wPFJoEd z@lqZu!#pA)iEpyAvjIF>(zESEa$r(LXJ14Q6(bAl#ygPQZlncjYPLB*>g8|oqM{-ojW?lCCGA2K&hkqF ztUpI4{b+N-V6KCxh z68&xVx=F<{6=KY=k#R8%_vFvk<5LQC-xCi;xdyJxUwcsS@qL?UU|jc%=f1v<2McyN*@V5yx8rvMTR7rTSaH)I;gZ!HPXd5eJhF0f zXaIY@8fMG*P>;1l0gaKryT6Z2G{>|ZainQJ$90YjFm8k(ACZ=$c30g4Jqd*DSO0E% zaq`0l;7=|I3Hk_NhKw0KOK*sS7|6ovRlx#N!Q1}$J6mzcj(D!qe?-2yJz!a0%Lpo{ zKbZ|czu29R($Uv1#2Ci(_Nu}!POa$7%*=R>i&yd-jWs+gEWJrA@P2ctbunU-Go=#Ml8W9+Z!T*s9ka&)d;(?n>LxpVbK$3FXY&gSNOg6}&v7h^r+Y#r<>mPW1tdyJ zO3p4WXh4Oa(X;?UGs}3#?(QycegANaiHRvq$XvtCO*jVnF?-I}pSVtmBy{i*NoZW{ z@mZAL_)t#ns5_~@G5_&kKx{t$$y0$cf}Bgtlg|TFiIr8KWKU*1D48Tb;D+Vi64zVN>%4I9Fn=`_-SqgNvH-g7zARm92cfpiDUSJ15X9prs#}A z{^7lfWNqD*a0>eF1~duJV6METi3zj2yZej3M-xEeuCxbUE?{A2C%&ac{^H^Sm|UQb zRcxr*nBw;gRVDcjZjoHvmQHy~b5bmYl$_%tgv)PVL`IYH*4EAXNbe5r+_l}xn+0;X zUX$Xy66l+>rM6tsKh$QVblCn?*10|lP(l>Q)-p|+dEOm((`iroi)2H^fSyk}gW66s zB26t6@sw+AVcS3IS1V-JmaXFparAt;#yn-Eu=kUlQdYd~cTm*1J=|P!tOvCJ({m;; z5Ss`M@wYHKHer5Z^-nEAJJ+te6*o)N6)Z}UF>Z5h2X*hQ*BPFl48E7r)}igA)ChuvB*6qm1ZZIsm_6GX zB-H6jxI>WlAd|+MZq;>f?4SXWM>~T-@C7VD@OA15) literal 0 HcmV?d00001 diff --git a/cypress/snapshots/base/AppNavigationItem.cy.ts/NcAppNavigationItem-primary-on-active-entry.png b/cypress/snapshots/base/AppNavigationItem.cy.ts/NcAppNavigationItem-primary-on-active-entry.png new file mode 100644 index 0000000000000000000000000000000000000000..2d4cdf5428266a8a8a9c2ab6b58793be68106051 GIT binary patch literal 2409 zcmV-v36}PWP)7idyk}U-(oL*6D_3i3uAQafva+LFm!qPcby>MA zn=B93w6(lWaf+ApRWn7+6hu)06~cH01(DnP8}CUr4l@;j5Z>?eC|!YCNY5=`<-v4P zvh&HX6_8;oB*Rv~rQ$M#5Kcl;&MhM|-G@vvnMV(M^ChsyM-$~%Ewk`O0(!KN!^5aGfZeZh) zvxL32l4X0-uxo@6&PY)~QTG(d-{y1oyfw^Se~23~xsHWflZpBCOUkuI2qEgz>@`WG z+X`6x%R&4QlWWi#rmfh+!fnY2A;gd6!=0%lXXml~_oFZj{*S>me6S;hh1-%5LO3H$ zL)v*FhhKfPoog|u#+sJHwB>scLO3f$LtD1@B=2oYraFTvGA|S|c2Odwc8w51G^A&i z@8Qc+=c&q|il^eOoG-Y75W)#*ZYvrXwQw_48CVF-Ehp{#Mc&(%!lExysB35Dk7wc5 zqs-rU7$KS*MZH@3S9nSz{i6*VU_T+`yPciEMgyB#U<(%9moT$0UZ%0~vY0q{x|u|Wcc5QzYbM9< zq*7aN5AusjnDNwP5b3FOc4uojblm--aX$F~hs#5ajEL_4x;hd@F(e3)b=Fsq@^b z;?i==?EE4cBTtLTr9VGTRe##_4RO1UQ|UmajRTo`sg#(K#iim>7Ch9K*=v$;hz<{8 zP^UHwe=C74$FjJd@bBOwn zNz_JBSs7+tQ3;JvQE53N-cG>5;_AXZ!L6A+DjZv3F|i3>Q|YO}U70c@gpRG6<7F{1 zl)}};z{_G%P+Uf2w*WG1g={&N#q~sVXvGU7!}w%x8dI0=K_f&Hpr|vk(Gkpy3ZuF> zYbvu=CsAAFc8%$7x=>tZr?IiyH9OOCsFawJg{Q^j<##UI&piXW1@bN*on=TX-m*MAWAuInfHxe1r4lj#Iob@;wA({vcC~7S>I)a%| zVN@4qO=VKNl{%rp@b~ecsYuDr$6~tBv6UANK1 z?R=VXBX4d#!kR-FYbvRqN>D{a|HQ%5*gBt>nXR}d2GpczB>IKn`5Hr=;wtHjh

mA`jP4o8=$?T*+`9t{#`fWvVWIpp=``OJ z7UPhZa*jv)-AULTE%A1D<%JPF8QR64s#YJ&V8`)q`TXffW<1b?5qAaf>j7POcYJ@U zD=D}0@CREso^z4J=}`pucp!wcij9t7W>gr}#aUCC6mO-jd0SjD!vlR;vHui}jk~K0 zYkzk?4kcxF(rpF2vH2V3Z8$`wx$6(%@7;`T&pn8Xq1brjEYB?8&9aI2QmI^PMlJj| zbE6}8?tvcoHnWg7Ek^A)Jr~6g9FvHJex09l*hMxrBGN z9Hl;mv~7W5C`>9ub-#n9drlyPa7G$X)Wo*bEViX)@nad&D-Z{R3Xk-?lV0sxB7|^4 zN^v`DZZU}++Xn}OtLBgGix5KGZeIIY1eFY~it2s`_jd6|2;rnOw;exEcVdQzQpuo- z_=!Vl?d6UT!U-vED+<^!^?s@{s3NeXC!aqZiL0RyLWqX+{)B<_4Q@?U2GtDi+?ID9 z>5mY?S!o*D#DQIyG9-lR46fnnq22h+kPw6r&Pai#!Q9iaHA|it%(WQ&fcGa1WZA@_ zxVabzA)Jh&K}?GbWzUPF`5`9PF`-{4I{Gzd+~O^q%P&F*A?kyn;DZT+m^`>E*W>a^ z1+F8|*OQ5Zx>8zhXMcJw)f00000NkvXXu0mjfA|b0B literal 0 HcmV?d00001 diff --git a/cypress/snapshots/base/AppNavigationItem.cy.ts/NcAppNavigationItem-tertiary-non-active-entry.png b/cypress/snapshots/base/AppNavigationItem.cy.ts/NcAppNavigationItem-tertiary-non-active-entry.png new file mode 100644 index 0000000000000000000000000000000000000000..ad36205d68c1e6dda43debfb61ffb04390475cf2 GIT binary patch literal 801 zcmeAS@N?(olHy`uVBq!ia0y~yVAKJ!bvW377PGmU# zaQ^#c!fovv)wtPmnJ@G3@njirNX>Cf|IEBBb;mY^bt?~U$lRdy;y{AYkH%0z7WO3J z7S)-h=~Z)ff7j!Av;ED~|DQ|#{A3ptl z^UsrWa(bqnJn1=a-n<<Q41)^-wu<<_wRvw)T%2yIFDZ@sjfL>hsSRmz5p6dslYx;>99dtS(FT{@56? zHEQX~u+@c?m7Xg@lCrbAr+xokUR70fB5kup-{I4zxm%qWua}-oG5Ry*^iz-Jm!A|_ z?%TIdVB)vO$Ah*;^&ULvSQix)l~h(XZCZwjmx#}t&x zjQ%K{KY!lj>$h*0p6t@=d;H<@)vKaPN$U2~e*OFR?Afz6wez1frh3W9${HFPI$Fpq z)0FEkuB!4uyu<}nf{ZF5!&a$$$?sQSo(bLE-3h$3MmPe`2MgyS$v(LdUJIiFzGXRy85}Sb4q9e07m0njsO4v literal 0 HcmV?d00001 diff --git a/cypress/visual/AppNavigationItem.cy.ts b/cypress/visual/AppNavigationItem.cy.ts index 893ac589fb..7f10f036b2 100644 --- a/cypress/visual/AppNavigationItem.cy.ts +++ b/cypress/visual/AppNavigationItem.cy.ts @@ -7,7 +7,13 @@ import NcAppNavigationItem from '../../src/components/NcAppNavigationItem/NcAppN describe('NcAppNavigationItem', () => { describe('With router link', () => { const RouterComponent = defineComponent({ - template: '
', + template: ` +
+ + + + +
`, components: { NcAppNavigationItem }, }) @@ -41,5 +47,20 @@ describe('NcAppNavigationItem', () => { cy.contains('.app-navigation-entry', 'Home').find('.app-navigation-entry__actions').click() cy.get('.app-navigation-entry--editing').compareSnapshot('NcAppNavigationItem-primary-on-active-route-menu-active') }) + + // Entries without router + + it('has tertiary styling on non active entry', () => { + cy.contains('.app-navigation-entry', 'Bar').compareSnapshot('NcAppNavigationItem-tertiary-non-active-entry') + }) + + it('has primary styling on active entry', () => { + cy.contains('.app-navigation-entry', 'Back').compareSnapshot('NcAppNavigationItem-primary-on-active-entry') + }) + + it('has primary button styling on active entry with editing=true', () => { + cy.contains('.app-navigation-entry', 'Back').find('.app-navigation-entry__actions').click() + cy.get('.app-navigation-entry--editing').compareSnapshot('NcAppNavigationItem-primary-on-active-entry-menu-active') + }) }) })