Skip to content

Commit

Permalink
fix: employee remider settings (frappe#27365) (frappe#27366)
Browse files Browse the repository at this point in the history
(cherry picked from commit 88c9fe3)

Co-authored-by: Anupam Kumar <anupamvns0099@gmail.com>
  • Loading branch information
frappe-pr-bot and anupamvs authored Sep 6, 2021
1 parent 1708e8b commit 821d55b
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions erpnext/hr/doctype/employee/employee_reminders.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,15 @@
# HOLIDAY REMINDERS
# -----------------
def send_reminders_in_advance_weekly():
to_send_in_advance = int(frappe.db.get_single_value("HR Settings", "send_holiday_reminders") or 1)
to_send_in_advance = int(frappe.db.get_single_value("HR Settings", "send_holiday_reminders"))
frequency = frappe.db.get_single_value("HR Settings", "frequency")
if not (to_send_in_advance and frequency == "Weekly"):
return

send_advance_holiday_reminders("Weekly")

def send_reminders_in_advance_monthly():
to_send_in_advance = int(frappe.db.get_single_value("HR Settings", "send_holiday_reminders") or 1)
to_send_in_advance = int(frappe.db.get_single_value("HR Settings", "send_holiday_reminders"))
frequency = frappe.db.get_single_value("HR Settings", "frequency")
if not (to_send_in_advance and frequency == "Monthly"):
return
Expand Down Expand Up @@ -79,7 +79,7 @@ def send_holidays_reminder_in_advance(employee, holidays):
# ------------------
def send_birthday_reminders():
"""Send Employee birthday reminders if no 'Stop Birthday Reminders' is not set."""
to_send = int(frappe.db.get_single_value("HR Settings", "send_birthday_reminders") or 1)
to_send = int(frappe.db.get_single_value("HR Settings", "send_birthday_reminders"))
if not to_send:
return

Expand Down

0 comments on commit 821d55b

Please sign in to comment.