Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time not attributed to boto3 #1230

Open
daveisfera opened this issue Oct 9, 2024 · 2 comments
Open

Time not attributed to boto3 #1230

daveisfera opened this issue Oct 9, 2024 · 2 comments
Labels

Comments

@daveisfera
Copy link

New Relic profile incorrectly shows a few ms for the time to download/upload a file that takes several seconds

Description
boto3 was instrumented with the fix in #1178 but the time used by the download/upload of the file from/to S3 is attributed to the Python code that calls that rather than that function

Expected Behavior
Time would be correctly attributed to the boto3 code rather than the caller

Steps to Reproduce

  1. Run Python code that uses boto3 to download/upload a file from/to S3
  2. View profile information in New Relic
  3. Observe that time show for the GET and HEAD calls to S3 are very small rather than the multiple seconds it takes

Your Environment
Python 3.12.7 with Debian Bookworm

@workato-integration
Copy link

@hmstepanek
Copy link
Contributor

Hey @daveisfera I was looking at this and I'm not necessarily seeing huge amounts of time missing like you are but my test env might be a little closer to the s3 bucket than yours. If you add the following function trace around the s3 download/upload call-what do you see in terms of time breakdown? Does the function trace capture the missing time or no?

    with newrelic.agent.FunctionTrace("download_file", 'Botocore/s3'):
        client.download_file(Bucket=ARN, Key='aiobotocore/dummy.bin', Filename='/tmp/dummy.bin')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants