Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[𝛆] Stop using absolute url for timeline js #1522

Open
3 of 4 tasks
nmorduch opened this issue Apr 27, 2020 · 3 comments
Open
3 of 4 tasks

[𝛆] Stop using absolute url for timeline js #1522

nmorduch opened this issue Apr 27, 2020 · 3 comments
Assignees
@chigby
Labels
someday

Comments

@nmorduch
Copy link
Contributor

nmorduch commented Apr 27, 2020 •
edited
Loading

Examples of instances where we're using absolute urls and shouldn't be:
@nmorduch nmorduch added the tbx label Apr 27, 2020
@nmorduch nmorduch changed the title Stop using absolute urls for static files etc [1hr] Stop using absolute urls for static files etc Aug 19, 2020
@nmorduch nmorduch added the 3 low label Aug 19, 2020
@nmorduch
Copy link
Contributor Author

check out EXTRA_STATIC_URL in settings, can pull that into the template

@nmorduch nmorduch removed the tbx label Oct 5, 2020
@nmorduch nmorduch mentioned this issue Oct 21, 2020
Merged
@nmorduch nmorduch linked a pull request Oct 21, 2020 that will close this issue
Pdf images #1568
Merged
@nmorduch
Copy link
Contributor Author

nmorduch commented Oct 21, 2020 •
edited
Loading

This has been causing problems in the pdf while we're testing the Wagtail 10.2 update

@nmorduch nmorduch added this to the Wagtail 2.10 milestone Oct 21, 2020
@nmorduch nmorduch removed a link to a pull request Oct 21, 2020
Pdf images #1568
Merged
@nmorduch nmorduch changed the title [1hr] Stop using absolute urls for static files etc [1hr] Stop using absolute url for timeline js Oct 21, 2020
@nmorduch nmorduch removed this from the Wagtail 2.10 milestone Oct 21, 2020
@nmorduch nmorduch changed the title [1hr] Stop using absolute url for timeline js [0.5h] Stop using absolute url for timeline js Nov 2, 2020
@nmorduch nmorduch assigned chigby and unassigned emilytoppm Jan 19, 2021
@nmorduch nmorduch changed the title [0.5h] Stop using absolute url for timeline js [𝛆] Stop using absolute url for timeline js Jan 19, 2021
@chigby
Copy link
Contributor

chigby commented Jan 21, 2021

Note: this was changed to the absolute URL in #1518

@nmorduch nmorduch closed this as completed Feb 2, 2021
@nmorduch nmorduch removed the 3 low label Feb 2, 2021
@nmorduch nmorduch reopened this Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chigby chigby

Labels
someday
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chigby @nmorduch @emilytoppm