Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature_perc #20

Open
amissarova opened this issue Jul 19, 2022 · 7 comments
Open

Feature_perc #20

amissarova opened this issue Jul 19, 2022 · 7 comments

Comments

@amissarova
Copy link

Hi!

I was wondering about the rationale for feature_perc = 0.5 and not 1? Are any particular reasons to randomly select features (besides computational complexity)?

Thanks!

@skinnider
Copy link
Collaborator

Nope, just a way to reduce the runtime.

@amissarova
Copy link
Author

cool, thanks

@amissarova
Copy link
Author

related q: I just tried running augur with feature_perc = 1. I would have expected that for each gene, each subsampling and each fold I will now get importance score - but it is not the case (there are some subsampling where I dont have an input for this gene). Why?
Thanks!

@skinnider
Copy link
Collaborator

By default 50% of genes will be filtered out with select_variance - are they there when setting var_quantile=0?

@amissarova
Copy link
Author

Hey,
I now set feature_perc = 1 and var_quantile = 0 --> for some genes, I still dont have an importance score entry for some of the subsamplings.

@amissarova
Copy link
Author

Guess that possibly happens coz of the initial hard-coded filtering of genes with no variance (for given downsampling)? Or are there some other reasons?

@skinnider
Copy link
Collaborator

That seems plausible, yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants