Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type hinting setup overhaul #175

Closed
5 tasks
Kircheneer opened this issue Nov 1, 2022 · 0 comments · Fixed by #219
Closed
5 tasks

Type hinting setup overhaul #175

Kircheneer opened this issue Nov 1, 2022 · 0 comments · Fixed by #219
Assignees
@Kircheneer
Labels
status: accepted This issue has been accepted by the maintainers team for implementation type: housekeeping
Milestone
2.0.0

Comments

@Kircheneer
Copy link
Collaborator

Kircheneer commented Nov 1, 2022 •
edited
Loading

Currently mypy uses an implicit configuration. We should do the followings things:

  • In what ways do we want to deviate from the default config?
  • Add a tool.mypy section to pyproject.toml
  • Make sure the configuration is used in the CI
  • Make sure we support Python <3.9 by using List, Dict etc. from typing rather than list
  • Drop all type hints from doc strings
@Kircheneer Kircheneer added status: accepted This issue has been accepted by the maintainers team for implementation type: housekeeping labels Nov 1, 2022
@Kircheneer Kircheneer self-assigned this Nov 1, 2022
@Kircheneer Kircheneer changed the title Make Mypy configuration explicit Type hinting setup overhaul Nov 1, 2022
@Kircheneer Kircheneer mentioned this issue Nov 1, 2022
Merged
@Kircheneer Kircheneer added this to the 2.0.0 milestone Nov 3, 2022
@Kircheneer Kircheneer mentioned this issue Nov 8, 2022
Closed
1 task
@Kircheneer Kircheneer mentioned this issue Mar 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kircheneer Kircheneer

Labels
status: accepted This issue has been accepted by the maintainers team for implementation type: housekeeping
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

Type hinting overhaul. networktocode/diffsync
1 participant
@Kircheneer