Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authorize on timeout #1398

Closed
glazychev-art opened this issue Dec 16, 2022 · 2 comments
Closed

Authorize on timeout #1398

glazychev-art opened this issue Dec 16, 2022 · 2 comments
Assignees

Comments

@glazychev-art
Copy link
Contributor

Current Behavior

Now there may be a problem with closing the connection on timeout, since the timeout mostly happens when the token expires.
After that, Close is called, but it fails on authorize, because token is already expired.

Steps to Reproduce

  1. Step 1
  2. Step 2
  3. You get the idea...

Context

  • Kubernetes Version:
  • etc.

Failure Logs

@glazychev-art glazychev-art moved this to In Progress in Release v1.8.0 Dec 19, 2022
@glazychev-art glazychev-art self-assigned this Dec 19, 2022
@glazychev-art
Copy link
Contributor Author

glazychev-art commented Dec 20, 2022

The general idea is to call timeout/expire in advance, considering the request timeout.

Steps:

  • networkservice: consider request timeout before calling Close
  • networkservice: sandbox test - 2h
  • registry: updatepath should update nse.ExpirationTime (skipped values here)
  • registry: expire updates expirationTime to default value only if it was not set. Call Unregister in advance
  • registry: sandbox test - 2h
  • manual integration testing

@denis-tingaikin
Copy link
Member

Fixed by #1404

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants