Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

device selector containing interface not known to host #658

Closed
zolug opened this issue Jun 8, 2022 · 1 comment
Closed

device selector containing interface not known to host #658

zolug opened this issue Jun 8, 2022 · 1 comment
Assignees
Labels
question Further information is requested

Comments

@zolug
Copy link
Contributor

zolug commented Jun 8, 2022

A device selector file might contain devices that do not exist on the host when the forwarder is starting.

Devices are stored in a map, thus it's non-deterministic when InitLinks() will try to process the missing interface, but when it does it will return without considering the remaining devices. (The outcome might be different among the running vpp forwarders.)
This might result in issues when for example trying to use Remote VLAN NSE with an interface that got ignored, hence the forwarder/vpp will not know about it.

IMHO an error during InitLinks should either be considered fatal, or the code should filter out devices that does not exist on the host without skipping others.

So, basically the question is if a device selector file with unknown interfaces is considered an error or not.

@zolug
Copy link
Contributor Author

zolug commented Jun 24, 2022

Thanks, the PR seems to work perfectly.

@LionelJouin LionelJouin moved this to 📋 To Do in Meridio Aug 29, 2022
@zolug zolug closed this as completed Oct 10, 2022
@LionelJouin LionelJouin moved this from 📋 To Do to ✅ Done in Meridio Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants