Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethink how we handle configs #28

Open
tashcan opened this issue Mar 27, 2024 · 0 comments
Open

Rethink how we handle configs #28

tashcan opened this issue Mar 27, 2024 · 0 comments

Comments

@tashcan
Copy link
Collaborator

tashcan commented Mar 27, 2024

Right now, config is part of mods, in a single file, with a lot of hand written reads with defaults defined as part of the load process.
I feel like this is getting a bit fragile, and also disconnects the mapping of a named config value from what is actually used throughout the code.

Thinking a little ahead, with us now having a bit of a UI on Mac and maybe something coming for windows too, if we were to decide to add config into those that would result in a lot of duplicate code, which is very fragile and will fall apart in some way.

Proposal:

Create a new config system, split it out into a standalone module with a C API that can be used across the patch and all the UIs to have a unified way of how a config works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant