Skip to content
This repository has been archived by the owner on Sep 6, 2024. It is now read-only.

Installation log #12

Closed
hugovalente-pm opened this issue Oct 28, 2022 · 21 comments
Closed

Installation log #12

hugovalente-pm opened this issue Oct 28, 2022 · 21 comments
Assignees
Labels
enhancement New feature or request

Comments

@hugovalente-pm
Copy link

When installing from the command line (with the command below) it would be nice to see some output of the installation on the window you triggered it or leave the last one open pending a user "enter" or something to see some output.

msiexec.exe /i netdata.msi TOKEN=jyx4ymCG5goYv96cG4cZuMx9kT371_bIj8nmqW-HCN267fVfT8no8geHnq30H4SumIhQrDiwCrc5-iJrSj31SLmTV3fNxrJJ1gZMBmjAhCvLNslYtetAsj6zleaKXBvHRH_ofSc URL=https://app.netdata.cloud/
@dfpr
Copy link
Contributor

dfpr commented Oct 28, 2022

Leaving a terminal open would interfere with unattended installations, I'll add a logging output file to the installer.

@cakrit
Copy link
Contributor

cakrit commented Oct 31, 2022

Please update here and document in the README when the logging output file is there.

@cakrit
Copy link
Contributor

cakrit commented Nov 3, 2022

@dfpr reminder that we still need the logfile. Installer didn't work and I don't know why.

@dfpr
Copy link
Contributor

dfpr commented Nov 3, 2022

@cakrit I'm working on this right now, I'll finish soon

@cakrit
Copy link
Contributor

cakrit commented Nov 3, 2022

noob question, isn't it possible to add our log (debug) messages to the output of
msiexec /i netdata.msi /L*vx "C:\folder\ExampleLogFilename.txt"

@cakrit
Copy link
Contributor

cakrit commented Nov 3, 2022

I mean, instead of doing our own thing...

@dfpr
Copy link
Contributor

dfpr commented Nov 3, 2022

noob question, isn't it possible to add our log (debug) messages to the output of

msiexec /i netdata.msi /L*vx "C:\folder\ExampleLogFilename.txt"

Usual msi logs include file operations and return codes of actions, output for scripts won't appear there so there's a need for saving a log file outside Windows Installer.

@cakrit
Copy link
Contributor

cakrit commented Nov 3, 2022

Ok, thanks.

@dfpr
Copy link
Contributor

dfpr commented Nov 3, 2022

Installation log now saved to c:\netdata.log, README has been updated.

@cakrit
Copy link
Contributor

cakrit commented Nov 4, 2022

I see garbage in netdata.log. The following is from notepad++, MS Word doesn't know what to do with it.

image

@dfpr
Copy link
Contributor

dfpr commented Nov 4, 2022

I see garbage in netdata.log. The following is from notepad++, MS Word doesn't know what to do with it.

image

Might be that wsl.exe outputs double byte characters when ansi is expected. Send me the log please.

@cakrit
Copy link
Contributor

cakrit commented Nov 4, 2022

Here it is cleaned up (installation failed): netdata.log

Here is the original: netdata.log

I see that Wordpad is able to open both, actually, those nulls (\x00) show up as extra spaces.

@dfpr
Copy link
Contributor

dfpr commented Nov 4, 2022

wsl.exe is outputting unicode, check microsoft/WSL#4607 .The fix shown there didn't work for me thou. For now the null character can be removed for readability. I'll work on the installation failed issue first before fixing this.

@cakrit
Copy link
Contributor

cakrit commented Nov 7, 2022

As mentioned in #10 the log also includes some errors that aren't really errors.

@cakrit cakrit added the enhancement New feature or request label Nov 7, 2022
@cakrit cakrit changed the title Feedback from installation Installation log Nov 7, 2022
@dfpr
Copy link
Contributor

dfpr commented Nov 10, 2022

I've improved the log file to show the least of errors, what might remain are faux error messages unrelated to the installation and caused by incorrect return codes plus unexpected unicode output from wsl.exe

@cakrit
Copy link
Contributor

cakrit commented Nov 21, 2022

Are the following "faux error messages"? Any suggestions on how to get rid of them?

SUCCESS: Specified value was saved.
ADDING SCRIPTS TO PATH
cmd.exe : ERROR: Invalid syntax. Default option is not allowed more than '2' time(s).
At C:\Netdata\install.ps1:166 char:2
+     cmd.exe /c setx /m PATH "%PATH%;C:\Netdata"
+     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (ERROR: Invalid ...an '2' time(s).:String) [], RemoteException
    + FullyQualifiedErrorId : NativeCommandError
 
Type "SETX /?" for usage.
STARTING AGENT
cmd.exe : 2022-11-21 14:39:54: netdata INFO  : MAIN : CONFIG: cannot load cloud config 
'/var/lib/netdata/cloud.d/cloud.conf'. Running with internal defaults.
At C:\Netdata\install.ps1:193 char:1
+ cmd.exe /c wsl -d netdata netdata
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (2022-11-21 14:3...ernal defaults.:String) [], RemoteException
    + FullyQualifiedErrorId : NativeCommandError

@dfpr
Copy link
Contributor

dfpr commented Nov 22, 2022

Are the following "faux error messages"? Any suggestions on how to get rid of them?

SUCCESS: Specified value was saved.
ADDING SCRIPTS TO PATH
cmd.exe : ERROR: Invalid syntax. Default option is not allowed more than '2' time(s).
At C:\Netdata\install.ps1:166 char:2
+     cmd.exe /c setx /m PATH "%PATH%;C:\Netdata"
+     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (ERROR: Invalid ...an '2' time(s).:String) [], RemoteException
    + FullyQualifiedErrorId : NativeCommandError
 
Type "SETX /?" for usage.
STARTING AGENT
cmd.exe : 2022-11-21 14:39:54: netdata INFO  : MAIN : CONFIG: cannot load cloud config 
'/var/lib/netdata/cloud.d/cloud.conf'. Running with internal defaults.
At C:\Netdata\install.ps1:193 char:1
+ cmd.exe /c wsl -d netdata netdata
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (2022-11-21 14:3...ernal defaults.:String) [], RemoteException
    + FullyQualifiedErrorId : NativeCommandError

I don't experience this issue but it should be fixed now for the setx command .
Also, installation script window doesn't show misleading red text now.

@cakrit
Copy link
Contributor

cakrit commented Nov 23, 2022

Yesterday's build had the following:

ADDING SCRIPTS TO PATH
cmd.exe : ERROR: Invalid syntax. Default option is not allowed more than '2' time(s).
At C:\Netdata\install.ps1:167 char:2
+     cmd.exe /c setx /m PATH "%PATH%;C:\Netdata" | Out-Null
+     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (ERROR: Invalid ...an '2' time(s).:String) [], RemoteException
    + FullyQualifiedErrorId : NativeCommandError
 
Type "SETX /?" for usage.

@dfpr
Copy link
Contributor

dfpr commented Nov 23, 2022

I need the full log

@dfpr
Copy link
Contributor

dfpr commented Nov 29, 2022

Path is added now through Windows Installer, uninstaller can fix old leftover entries.

@cakrit
Copy link
Contributor

cakrit commented Nov 30, 2022

I'm closing this and will create a new one if I see any new weird things.

@cakrit cakrit closed this as completed Nov 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants