Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple LDAP group support #210

Closed
a-chartier opened this issue May 11, 2024 · 0 comments · Fixed by #318
Closed

Multiple LDAP group support #210

a-chartier opened this issue May 11, 2024 · 0 comments · Fixed by #318
Labels
enhancement New feature or request
Milestone

Comments

@a-chartier
Copy link

I very well may be missing something so please tell me if that's the case.

Currently the following value keys

remoteAuth.ldap.requireGroupDn
remoteAuth.ldap.isAdminDn
remoteAuth.ldap.isSuperUserDn

Only support a single string entry, Ideally they could be changed to support multiple inputs

remoteAuth:
  ldap:
    requireGroupDn:
      -  CN=<sample>,OU=<sample>,OU=<sample>,OU=<sample>,DC=example,DC=com
      -  CN=<super sample>,OU=<sample>,OU=<sample>,OU=<sample>,DC=example,DC=com

This would mean changing the Helm template relevant sections to support the following setup

AUTH_LDAP_REQUIRE_GROUP = (
    (
        LDAPGroupQuery("CN=<sample>,OU=<sample>,OU=<sample>,OU=<sample>,DC=example,DC=com") |
        LDAPGroupQuery("CN=<super sample>,OU=<sample>,OU=<sample>,OU=<sample>,DC=example,DC=com") 
    )
)

I would be willing to make a PR on this if it's something that would be entertained. The relevant django section is here

This would allow LDAP integration to allow for much more granular access control within the Helm deployment.

Thanks

@LeoColomb LeoColomb changed the title [LDAP] - Multiple group support Multiple LDAP group support Jun 13, 2024
@RangerRick RangerRick added the enhancement New feature or request label Jul 22, 2024
@LeoColomb LeoColomb added this to the 5.0 bugfixes milestone Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants