Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Userspace implementation of RemoveAllowedIP recreates wireguard iface #1912

Closed
hurricanehrndz opened this issue May 2, 2024 · 3 comments · Fixed by #1913
Closed

Userspace implementation of RemoveAllowedIP recreates wireguard iface #1912

hurricanehrndz opened this issue May 2, 2024 · 3 comments · Fixed by #1913

Comments

@hurricanehrndz
Copy link
Contributor

Describe the problem

RemoveAllowedIP is not an update operation. Because of this when this function is called on platforms depending on the user space implementation of wireguard it results in all connections being dropped because it tries to use a port that is already in use.

To Reproduce

Steps to reproduce the behavior:
Deselect one of the routes from the new "Network Routes" menu

Expected behavior

Expect removing an IP from peer ACL does not recreate wireguard interface

Are you using NetBird Cloud?
NA

NetBird version

main

NetBird status -d output:

Not applicable

Screenshots

If applicable, add screenshots to help explain your problem.

Additional context

Add any other context about the problem here.

@hurricanehrndz
Copy link
Contributor Author

@mlsmaycon latency base routing will not work without fixing this bug, because routes need to be successfully removed from allowed list without recreating wg iface

@hurricanehrndz hurricanehrndz changed the title Userspace implementation of RemoveAllowedIP recreates wireguard inface Userspace implementation of RemoveAllowedIP recreates wireguard iface May 2, 2024
@hurricanehrndz
Copy link
Contributor Author

I have a patch that fixes this

@mlsmaycon
Copy link
Collaborator

Ok, thanks @hurricanehrndz we will review it soon after you open the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants