From 522dd44bfa3f32dcb39ef97aa33a073564b03e02 Mon Sep 17 00:00:00 2001
From: "Krzysztof Nazarewski (kdn)" <gpg@kdn.im>
Date: Mon, 13 Jan 2025 10:15:01 +0100
Subject: [PATCH] [client] make /var/lib/netbird paths configurable (#3084)

- NB_STATE_DIR
- NB_UNCLEAN_SHUTDOWN_RESOLV_FILE
- NB_DNS_STATE_FILE
---
 client/configs/configs.go             | 24 ++++++++++++++++++++++++
 client/internal/dns/consts.go         | 18 ++++++++++++++++++
 client/internal/dns/consts_freebsd.go |  5 -----
 client/internal/dns/consts_linux.go   |  7 -------
 client/internal/statemanager/path.go  | 15 ++++-----------
 5 files changed, 46 insertions(+), 23 deletions(-)
 create mode 100644 client/configs/configs.go
 create mode 100644 client/internal/dns/consts.go
 delete mode 100644 client/internal/dns/consts_freebsd.go
 delete mode 100644 client/internal/dns/consts_linux.go

diff --git a/client/configs/configs.go b/client/configs/configs.go
new file mode 100644
index 00000000000..8f9c3ba2870
--- /dev/null
+++ b/client/configs/configs.go
@@ -0,0 +1,24 @@
+package configs
+
+import (
+	"os"
+	"path/filepath"
+	"runtime"
+)
+
+var StateDir string
+
+func init() {
+	StateDir = os.Getenv("NB_STATE_DIR")
+	if StateDir != "" {
+		return
+	}
+	switch runtime.GOOS {
+	case "windows":
+		StateDir = filepath.Join(os.Getenv("PROGRAMDATA"), "Netbird")
+	case "darwin", "linux":
+		StateDir = "/var/lib/netbird"
+	case "freebsd", "openbsd", "netbsd", "dragonfly":
+		StateDir = "/var/db/netbird"
+	}
+}
diff --git a/client/internal/dns/consts.go b/client/internal/dns/consts.go
new file mode 100644
index 00000000000..b333d080807
--- /dev/null
+++ b/client/internal/dns/consts.go
@@ -0,0 +1,18 @@
+//go:build !android
+
+package dns
+
+import (
+	"github.com/netbirdio/netbird/client/configs"
+	"os"
+	"path/filepath"
+)
+
+var fileUncleanShutdownResolvConfLocation string
+
+func init() {
+	fileUncleanShutdownResolvConfLocation = os.Getenv("NB_UNCLEAN_SHUTDOWN_RESOLV_FILE")
+	if fileUncleanShutdownResolvConfLocation == "" {
+		fileUncleanShutdownResolvConfLocation = filepath.Join(configs.StateDir, "resolv.conf")
+	}
+}
diff --git a/client/internal/dns/consts_freebsd.go b/client/internal/dns/consts_freebsd.go
deleted file mode 100644
index 64c8fe5ebed..00000000000
--- a/client/internal/dns/consts_freebsd.go
+++ /dev/null
@@ -1,5 +0,0 @@
-package dns
-
-const (
-	fileUncleanShutdownResolvConfLocation = "/var/db/netbird/resolv.conf"
-)
diff --git a/client/internal/dns/consts_linux.go b/client/internal/dns/consts_linux.go
deleted file mode 100644
index 15614b0c599..00000000000
--- a/client/internal/dns/consts_linux.go
+++ /dev/null
@@ -1,7 +0,0 @@
-//go:build !android
-
-package dns
-
-const (
-	fileUncleanShutdownResolvConfLocation = "/var/lib/netbird/resolv.conf"
-)
diff --git a/client/internal/statemanager/path.go b/client/internal/statemanager/path.go
index 6cfd79a1212..d232e5f0cb0 100644
--- a/client/internal/statemanager/path.go
+++ b/client/internal/statemanager/path.go
@@ -1,23 +1,16 @@
 package statemanager
 
 import (
+	"github.com/netbirdio/netbird/client/configs"
 	"os"
 	"path/filepath"
-	"runtime"
 )
 
 // GetDefaultStatePath returns the path to the state file based on the operating system
 // It returns an empty string if the path cannot be determined.
 func GetDefaultStatePath() string {
-	switch runtime.GOOS {
-	case "windows":
-		return filepath.Join(os.Getenv("PROGRAMDATA"), "Netbird", "state.json")
-	case "darwin", "linux":
-		return "/var/lib/netbird/state.json"
-	case "freebsd", "openbsd", "netbsd", "dragonfly":
-		return "/var/db/netbird/state.json"
+	if path := os.Getenv("NB_DNS_STATE_FILE"); path != "" {
+		return path
 	}
-
-	return ""
-
+	return filepath.Join(configs.StateDir, "state.json")
 }