Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Daily Nerd #90

Merged
merged 16 commits into from
Apr 11, 2024
Merged

Daily Nerd #90

merged 16 commits into from
Apr 11, 2024

Conversation

oma-s
Copy link
Contributor

@oma-s oma-s commented Apr 4, 2024

fixes #88

https://nerdgeschoss-feature-88-jew9sx.herokuapp.com/de

Review Notes:

To test the feature a current sprint is required. I created one on the review app.
You can use the user: daily@nerdgeschoss.de / password.
Once a specific users daily nerd message is created for a day, it can only be edited in the UI. In order to create it again you could destroy it via the CLI.

To test the integration to flink, join the flink_testing channel. To test that names and images are working it's necessary to test with a real slack users email address.

For example, you can create a user on the CLI like this and then login with the password:

User.create(first_name: "Daniel", last_name: "Diekmeier", email: "daniel@nerdgeschoss.de", roles: ["sprinter"], nick_name: "Daniel", password: "1234")

Messages support very simple markdown like bold, italic, code and code block.

@oma-s oma-s marked this pull request as ready for review April 8, 2024 19:56
@oma-s oma-s self-assigned this Apr 8, 2024
@oma-s oma-s temporarily deployed to nerdgeschoss-feature-88-l6sssp April 8, 2024 20:48 Inactive
@oma-s oma-s temporarily deployed to nerdgeschoss-feature-88-l6sssp April 8, 2024 20:49 Inactive
@oma-s oma-s temporarily deployed to nerdgeschoss-feature-88-jew9sx April 8, 2024 21:40 Inactive
Copy link
Contributor

@Maxi211 Maxi211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it in the review app, including some markdown and it worked like it should :)

Co-authored-by: Maximilian Langenbeck <max@nerdgeschoss.de>
@oma-s oma-s temporarily deployed to nerdgeschoss-feature-88-jew9sx April 10, 2024 07:08 Inactive
Copy link
Contributor

@danieldiekmeier danieldiekmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@oma-s oma-s temporarily deployed to nerdgeschoss-feature-88-jew9sx April 10, 2024 15:44 Inactive
@oma-s oma-s temporarily deployed to nerdgeschoss-feature-88-jew9sx April 11, 2024 03:29 Inactive
@danieldiekmeier danieldiekmeier mentioned this pull request Apr 11, 2024
@danieldiekmeier danieldiekmeier temporarily deployed to nerdgeschoss-feature-88-jew9sx April 11, 2024 09:57 Inactive
@ckroter ckroter merged commit 22d96e2 into main Apr 11, 2024
1 check passed
@ckroter ckroter deleted the feature/88_daily_nerd branch April 11, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Daily Nerd
5 participants