-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Daily Nerd #90
Merged
Merged
Daily Nerd #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oma-s
commented
Apr 8, 2024
oma-s
commented
Apr 8, 2024
Maxi211
requested changes
Apr 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested it in the review app, including some markdown and it worked like it should :)
Co-authored-by: Maximilian Langenbeck <max@nerdgeschoss.de>
danieldiekmeier
suggested changes
Apr 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
Closed
ckroter
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #88
https://nerdgeschoss-feature-88-jew9sx.herokuapp.com/de
Review Notes:
To test the feature a current sprint is required. I created one on the review app.
You can use the user:
daily@nerdgeschoss.de
/password
.Once a specific users daily nerd message is created for a day, it can only be edited in the UI. In order to create it again you could destroy it via the CLI.
To test the integration to flink, join the
flink_testing
channel. To test that names and images are working it's necessary to test with a real slack users email address.For example, you can create a user on the CLI like this and then login with the password:
Messages support very simple markdown like bold, italic, code and code block.